Inside Bitcoin
Opening the selected file…
Opening the selected file…
The code behind the network, with room to understand it.
Release published 2026-10-28 · Snapshot fetched 2026-11-01. Latest stable release at fetch time; development branches and Git history are excluded. Only the selected code window and visible folders load here.
1From d68fc6ecc88a0e4532754b1a9f209881a248f4ee Mon Sep 17 00:00:00 20012From: Giuseppe D'Angelo <[email protected]>3Date: Wed, 4 Feb 2026 12:33:08 +01004Subject: [PATCH] QByteArrayView: include qchar.h6QByteArrayView needs the complete definition of QChar in order to7define its relational operators against it.9In particular, the expansion of the11Q_DECLARE_STRONGLY_ORDERED(QByteArrayView, QChar, QT_ASCII_CAST_WARN)13macro creates an overload set where the QByteArrayView(Container)14constructor is considered. GCC complains that that constructor is15excluded via SFINAE for Container = QChar, not because QChar isn't a16suitable container (indeed, it's not), but because it's *incomplete* at17that point. When QChar is later completed, GCC is afraid that the18previous substitution failure might have yielded a different result,19and warns about it. Fix this by including QChar.21Task-number: QTBUG-14347022Change-Id: I705f91ef1133b59363df0cd6dbab91a5854e248c23Reviewed-by: Thiago Macieira <[email protected]>24Reviewed-by: Fabian Kosmale <[email protected]>25---26src/corelib/text/qbytearrayview.h | 1 +271 file changed, 1 insertion(+)29diff --git a/qtbase/src/corelib/text/qbytearrayview.h b/qtbase/src/corelib/text/qbytearrayview.h30index 7d3e82e72a02..b19f6fd5424e 10064431--- a/qtbase/src/corelib/text/qbytearrayview.h32+++ b/qtbase/src/corelib/text/qbytearrayview.h33@@ -4,6 +4,7 @@34#define QBYTEARRAYVIEW_H36#include <QtCore/qbytearrayalgorithms.h>37+#include <QtCore/qchar.h>38#include <QtCore/qcompare.h>39#include <QtCore/qcontainerfwd.h>40#include <QtCore/qstringfwd.h>
Independent explanations by MyBitcoinExplorer. Not affiliated with or endorsed by Bitcoin Core. Guides are educational and do not replace the source or its tests.
Bitcoin Core source © its contributors, distributed under the MIT license. Original notices and bundled third-party licenses are retained in the source tree.