Inside Bitcoin

501
502        // orphan in tx_mempool, template creation fails
503        hash = tx.GetHash();
504        TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).FromTx(tx));
505        BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
506    }
507
508    {
509        CTxMemPool& tx_mempool{MakeMempool()};
510        LOCK(tx_mempool.cs);
511
512        // child with higher feerate than parent
513        tx.vin[0].scriptSig = CScript() << OP_1;
514        tx.vin[0].prevout.hash = txFirst[1]->GetHash();
515        tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
516        hash = tx.GetHash();
517        TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
518        tx.vin[0].prevout.hash = hash;
519        tx.vin.resize(2);
520        tx.vin[1].scriptSig = CScript() << OP_1;
521        tx.vin[1].prevout.hash = txFirst[0]->GetHash();
522        tx.vin[1].prevout.n = 0;
523        tx.vout[0].nValue = tx.vout[0].nValue + BLOCKSUBSIDY - HIGHERFEE; // First txn output + fresh coinbase - new txn fee
524        hash = tx.GetHash();
525        TryAddToMempool(tx_mempool, entry.Fee(HIGHERFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
526        BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
527    }
528
529    {
530        CTxMemPool& tx_mempool{MakeMempool()};
531        LOCK(tx_mempool.cs);
532
533        // coinbase in tx_mempool, template creation fails
534        tx.vin.resize(1);
535        tx.vin[0].prevout.SetNull();
536        tx.vin[0].scriptSig = CScript() << OP_0 << OP_1;
537        tx.vout[0].nValue = 0;
538        hash = tx.GetHash();
539        // give it a fee so it'll get mined
540        TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
541        // Should throw bad-cb-multiple
542        BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-cb-multiple"));
543    }
544
545    {
546        CTxMemPool& tx_mempool{MakeMempool()};
547        LOCK(tx_mempool.cs);
548
549        // double spend txn pair in tx_mempool, template creation fails
550        tx.vin[0].prevout.hash = txFirst[0]->GetHash();
551        tx.vin[0].scriptSig = CScript() << OP_1;
552        tx.vout[0].nValue = BLOCKSUBSIDY - HIGHFEE;
553        tx.vout[0].scriptPubKey = CScript() << OP_1;
554        hash = tx.GetHash();
555        TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
556        tx.vout[0].scriptPubKey = CScript() << OP_2;
557        hash = tx.GetHash();
558        TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
559        BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("bad-txns-inputs-missingorspent"));
560    }
561
562    {
563        CTxMemPool& tx_mempool{MakeMempool()};
564        LOCK(tx_mempool.cs);
565
566        // subsidy changing
567        int nHeight = m_node.chainman->ActiveChain().Height();
568        // Create an actual 209999-long block chain (without valid blocks).
569        while (m_node.chainman->ActiveChain().Tip()->nHeight < 209999) {
570            CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
571            CBlockIndex* next = new CBlockIndex();
572            next->phashBlock = new uint256(m_rng.rand256());
573            m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
574            next->pprev = prev;
575            next->nHeight = prev->nHeight + 1;
576            next->BuildSkip();
577            m_node.chainman->ActiveChain().SetTip(*next);
578        }
579        BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
580        // Extend to a 210000-long block chain.
581        while (m_node.chainman->ActiveChain().Tip()->nHeight < 210000) {
582            CBlockIndex* prev = m_node.chainman->ActiveChain().Tip();
583            CBlockIndex* next = new CBlockIndex();
584            next->phashBlock = new uint256(m_rng.rand256());
585            m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(next->GetBlockHash());
586            next->pprev = prev;
587            next->nHeight = prev->nHeight + 1;
588            next->BuildSkip();
589            m_node.chainman->ActiveChain().SetTip(*next);
590        }
591        BOOST_REQUIRE(mining->createNewBlock(options, /*cooldown=*/false));
592
593        // invalid p2sh txn in tx_mempool, template creation fails
594        tx.vin[0].prevout.hash = txFirst[0]->GetHash();
595        tx.vin[0].prevout.n = 0;
596        tx.vin[0].scriptSig = CScript() << OP_1;
597        tx.vout[0].nValue = BLOCKSUBSIDY - LOWFEE;
598        CScript script = CScript() << OP_0;
599        tx.vout[0].scriptPubKey = GetScriptForDestination(ScriptHash(script));
600        hash = tx.GetHash();
601        TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
602        tx.vin[0].prevout.hash = hash;
603        tx.vin[0].scriptSig = CScript() << std::vector<unsigned char>(script.begin(), script.end());
604        tx.vout[0].nValue -= LOWFEE;
605        hash = tx.GetHash();
606        TryAddToMempool(tx_mempool, entry.Fee(LOWFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(false).FromTx(tx));
607        BOOST_CHECK_EXCEPTION(mining->createNewBlock(options, /*cooldown=*/false), std::runtime_error, HasReason("block-script-verify-flag-failed"));
608
609        // Delete the dummy blocks again.
610        while (m_node.chainman->ActiveChain().Tip()->nHeight > nHeight) {
611            CBlockIndex* del = m_node.chainman->ActiveChain().Tip();
612            m_node.chainman->ActiveChain().SetTip(*Assert(del->pprev));
613            m_node.chainman->ActiveChainstate().CoinsTip().SetBestBlock(del->pprev->GetBlockHash());
614            delete del->phashBlock;
615            delete del;
616        }
617    }
618
619    CTxMemPool& tx_mempool{MakeMempool()};
620    LOCK(tx_mempool.cs);
621
622    // non-final txs in mempool
623    clock.set(std::chrono::seconds{m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1});
624    const int flags{LOCKTIME_VERIFY_SEQUENCE};
625    // height map
626    std::vector<int> prevheights;
627
628    // relative height locked
629    tx.version = 2;
630    tx.vin.resize(1);
631    prevheights.resize(1);
632    tx.vin[0].prevout.hash = txFirst[0]->GetHash(); // only 1 transaction
633    tx.vin[0].prevout.n = 0;
634    tx.vin[0].scriptSig = CScript() << OP_1;
635    tx.vin[0].nSequence = m_node.chainman->ActiveChain().Tip()->nHeight + 1; // txFirst[0] is the 2nd block
636    prevheights[0] = baseheight + 1;
637    tx.vout.resize(1);
638    tx.vout[0].nValue = BLOCKSUBSIDY-HIGHFEE;
639    tx.vout[0].scriptPubKey = CScript() << OP_1;
640    tx.nLockTime = 0;
641    hash = tx.GetHash();
642    TryAddToMempool(tx_mempool, entry.Fee(HIGHFEE).Time(Now<NodeSeconds>()).SpendsCoinbase(true).FromTx(tx));
643    BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
644    BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
645
646    {
647        CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
648        BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 2, active_chain_tip))); // Sequence locks pass on 2nd block
649    }
650
651    // relative time locked
652    tx.vin[0].prevout.hash = txFirst[1]->GetHash();
653    tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | (((m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()+1-m_node.chainman->ActiveChain()[1]->GetMedianTimePast()) >> CTxIn::SEQUENCE_LOCKTIME_GRANULARITY) + 1); // txFirst[1] is the 3rd block
654    prevheights[0] = baseheight + 2;
655    hash = tx.GetHash();
656    TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
657    BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
658    BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
659
660    const int SEQUENCE_LOCK_TIME = 512; // Sequence locks pass 512 seconds later
661    for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i)
662        m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i)->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
663    {
664        CBlockIndex* active_chain_tip = m_node.chainman->ActiveChain().Tip();
665        BOOST_CHECK(SequenceLocks(CTransaction(tx), flags, prevheights, *CreateBlockIndex(active_chain_tip->nHeight + 1, active_chain_tip)));
666    }
667
668    for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
669        CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
670        ancestor->nTime -= SEQUENCE_LOCK_TIME; // undo tricked MTP
671    }
672
673    // absolute height locked
674    tx.vin[0].prevout.hash = txFirst[2]->GetHash();
675    tx.vin[0].nSequence = CTxIn::MAX_SEQUENCE_NONFINAL;
676    prevheights[0] = baseheight + 3;
677    tx.nLockTime = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
678    hash = tx.GetHash();
679    TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
680    BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
681    BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
682    BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast())); // Locktime passes on 2nd block
683
684    // ensure tx is final for a specific case where there is no locktime and block height is zero
685    tx.nLockTime = 0;
686    BOOST_CHECK(IsFinalTx(CTransaction(tx), /*nBlockHeight=*/0, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast()));
687
688    // absolute time locked
689    tx.vin[0].prevout.hash = txFirst[3]->GetHash();
690    tx.nLockTime = m_node.chainman->ActiveChain().Tip()->GetMedianTimePast();
691    prevheights.resize(1);
692    prevheights[0] = baseheight + 4;
693    hash = tx.GetHash();
694    TryAddToMempool(tx_mempool, entry.Time(Now<NodeSeconds>()).FromTx(tx));
695    BOOST_CHECK(!CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime fails
696    BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
697    BOOST_CHECK(IsFinalTx(CTransaction(tx), m_node.chainman->ActiveChain().Tip()->nHeight + 2, m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1)); // Locktime passes 1 second later
698
699    // mempool-dependent transactions (not added)
700    tx.vin[0].prevout.hash = hash;
701    prevheights[0] = m_node.chainman->ActiveChain().Tip()->nHeight + 1;
702    tx.nLockTime = 0;
703    tx.vin[0].nSequence = 0;
704    BOOST_CHECK(CheckFinalTxAtTip(*Assert(m_node.chainman->ActiveChain().Tip()), CTransaction{tx})); // Locktime passes
705    BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
706    tx.vin[0].nSequence = 1;
707    BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
708    tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG;
709    BOOST_CHECK(TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks pass
710    tx.vin[0].nSequence = CTxIn::SEQUENCE_LOCKTIME_TYPE_FLAG | 1;
711    BOOST_CHECK(!TestSequenceLocks(CTransaction{tx}, tx_mempool)); // Sequence locks fail
712
713    auto block_template = mining->createNewBlock(options, /*cooldown=*/false);
714    BOOST_REQUIRE(block_template);
715
716    // None of the of the absolute height/time locked tx should have made
717    // it into the template because we still check IsFinalTx in CreateNewBlock,
718    // but relative locked txs will if inconsistently added to mempool.
719    // For now these will still generate a valid template until BIP68 soft fork
720    CBlock block{block_template->getBlock()};
721    BOOST_CHECK_EQUAL(block.vtx.size(), 3U);
722    // However if we advance height by 1 and time by SEQUENCE_LOCK_TIME, all of them should be mined
723    for (int i = 0; i < CBlockIndex::nMedianTimeSpan; ++i) {
724        CBlockIndex* ancestor{Assert(m_node.chainman->ActiveChain().Tip()->GetAncestor(m_node.chainman->ActiveChain().Tip()->nHeight - i))};
725        ancestor->nTime += SEQUENCE_LOCK_TIME; // Trick the MedianTimePast
726    }
727    m_node.chainman->ActiveChain().Tip()->nHeight++;
728    clock.set(std::chrono::seconds{m_node.chainman->ActiveChain().Tip()->GetMedianTimePast() + 1});
729
730    block_template = mining->createNewBlock(options, /*cooldown=*/false);
731    BOOST_REQUIRE(block_template);
732    block = block_template->getBlock();
733    BOOST_CHECK_EQUAL(block.vtx.size(), 5U);
734}
735
736void MinerTestingSetup::TestPrioritisedMining(const CScript& scriptPubKey, const std::vector<CTransactionRef>& txFirst)
737{
738    auto mining{MakeMining()};
739    BOOST_REQUIRE(mining);
740
741    BlockCreateOptions options{
742        .coinbase_output_script = scriptPubKey,
743    };
744
745    CTxMemPool& tx_mempool{MakeMempool()};
746    LOCK(tx_mempool.cs);
747
748    TestMemPoolEntryHelper entry;
749
750    // Test that a tx below min fee but prioritised is included