Inside Bitcoin

751- #15203 Fix issue #9683 "gui, wallet: random abort (segmentation fault) (dooglus)
752- #15091 Fix model overlay header sync (jonasschnelli)
753- #15153 Add Open Wallet menu (promag)
754- #15183 Fix `m_assumed_blockchain_size` variable value (marcoagner)
755- #15063 If BIP70 is disabled, attempt to fall back to BIP21 parsing (luke-jr)
756- #15195 Add Close Wallet action (promag)
757- #15462 Fix async open wallet call order (promag)
758- #15801 Bugfix: GUI: Options: Initialise prune setting range before loading current value, and remove upper bound limit (luke-jr)
759
760### Build system
761- #13955 gitian: Bump descriptors for (0.)18 (fanquake)
762- #13899 Enable -Wredundant-decls where available. Remove redundant redeclarations (practicalswift)
763- #13665 Add RISC-V support to gitian (ken2812221)
764- #14062 Generate MSVC project files via python script (ken2812221)
765- #14037 Add README.md to linux release tarballs (hebasto)
766- #14183 Remove unused Qt 4 dependencies (ken2812221)
767- #14127 Avoid getifaddrs when unavailable (greenaddress)
768- #14184 Scripts and tools: increased timeout downloading (cisba)
769- #14204 Move `interfaces/*` to `libbitcoin_server` (laanwj)
770- #14208 Actually remove `ENABLE_WALLET` (jnewbery)
771- #14212 Remove libssl from LDADD unless GUI (MarcoFalke)
772- #13578 Upgrade zeromq to 4.2.5 and avoid deprecated zeromq API functions (mruddy)
773- #14281 lcov: filter /usr/lib/ from coverage reports (MarcoFalke)
774- #14325 gitian: Use versioned unsigned tarballs instead of generically named ones (achow101)
775- #14253 During 'make clean', remove some files that are currently missed (murrayn)
776- #14455 Unbreak `make clean` (jamesob)
777- #14495 Warn (don't fail!) on spelling errors (practicalswift)
778- #14496 Pin to specific versions of Python packages we install from PyPI in Travis (practicalswift)
779- #14568 Fix Qt link order for Windows build (ken2812221)
780- #14252 Run functional tests and benchmarks under the undefined behaviour sanitizer (UBSan) (practicalswift)
781- #14612 Include full version number in released file names (achow101)
782- #14840 Remove duplicate libconsensus linking in test make (AmirAbrams)
783- #14564 Adjust configure so that only BIP70 is disabled when protobuf is missing instead of the GUI (jameshilliard)
784- #14883 Add `--retry 5` to curl opts in `install_db4.sh` (qubenix)
785- #14701 Add `CLIENT_VERSION_BUILD` to CFBundleGetInfoString (fanquake)
786- #14849 Qt 5.9.7 (fanquake)
787- #15020 Add names to Travis jobs (gkrizek)
788- #15047 Allow to configure --with-sanitizers=fuzzer (MarcoFalke)
789- #15154 Configure: bitcoin-tx doesn't need libevent, so don't pull it in (luke-jr)
790- #15175 Drop macports support (Empact)
791- #15308 Restore compatibility with older boost (Empact)
792- #15407 msvc: Fix silent merge conflict between #13926 and #14372 part II (ken2812221)
793- #15388 Makefile.am: add rule for src/bitcoin-wallet (Sjors)
794- #15393 Bump minimum Qt version to 5.5.1 (Sjors)
795- #15285 Prefer Python 3.4 even if newer versions are present on the system (Sjors)
796- #15398 msvc: Add rapidcheck property tests (ken2812221)
797- #15431 msvc: scripted-diff: Remove NDEBUG pre-define in project file (ken2812221)
798- #15549 gitian: Improve error handling (laanwj)
799- #15548 use full version string in setup.exe (MarcoFalke)
800- #11526 Visual Studio build configuration for Bitcoin Core (sipsorcery)
801- #15110 build\_msvc: Fix the build problem in `libbitcoin_server` (Mr-Leshiy)
802- #14372 msvc: build secp256k1 and leveldb locally (ken2812221)
803- #15325 msvc: Fix silent merge conflict between #13926 and #14372 (ken2812221)
804- #15391 Add compile time verification of assumptions we're currently making implicitly/tacitly (practicalswift)
805- #15503 msvc: Use a single file to specify the include path (ken2812221)
806- #13765 contrib: Add gitian build support for github pull request (ken2812221)
807- #15809 gitignore: plist and dat (jamesob)
808
809### Tests and QA
810- #15405 appveyor: Clean cache when build configuration changes (Sjors)
811- #13953 Fix deprecation in bitcoin-util-test.py (isghe)
812- #13963 Replace usage of tostring() with tobytes() (dongcarl)
813- #13964 ci: Add appveyor ci (ken2812221)
814- #13997 appveyor: fetch the latest port data (ken2812221)
815- #13707 Add usage note to check-rpc-mappings.py (masonicboom)
816- #14036 travis: Run unit tests --with-sanitizers=undefined (MarcoFalke)
817- #13861 Add testing of `value_ret` for SelectCoinsBnB (Empact)
818- #13863 travis: Move script sections to files in `.travis/` subject to shellcheck (scravy)
819- #14081 travis: Fix missing differentiation between unit and functional tests (scravy)
820- #14042 travis: Add cxxflags=-wno-psabi at arm job (ken2812221)
821- #14051 Make `combine_logs.py` handle multi-line logs (jnewbery)
822- #14093 Fix accidental trunction from int to bool (practicalswift)
823- #14108 Add missing locking annotations and locks (`g_cs_orphans`) (practicalswift)
824- #14088 Don't assert(…) with side effects (practicalswift)
825- #14086 appveyor: Use clcache to speed up build (ken2812221)
826- #13954 Warn (don't fail!) on spelling errors. Fix typos reported by codespell (practicalswift)
827- #12775 Integration of property based testing into Bitcoin Core (Christewart)
828- #14119 Read reject reasons from debug log, not P2P messages (MarcoFalke)
829- #14189 Fix silent merge conflict in `wallet_importmulti` (MarcoFalke)
830- #13419 Speed up `knapsack_solver_test` by not recreating wallet 100 times (lucash-dev)
831- #14199 Remove redundant BIP174 test from `rpc_psbt.json` (araspitzu)
832- #14179 Fixups to "Run all tests even if wallet is not compiled" (MarcoFalke)
833- #14225 Reorder tests and move most of extended tests up to normal tests (ken2812221)
834- #14236 `generate` --> `generatetoaddress` change to allow tests run without wallet (sanket1729)
835- #14287 Use MakeUnique to construct objects owned by `unique_ptrs` (practicalswift)
836- #14007 Run functional test on Windows and enable it on Appveyor (ken2812221)
837- #14275 Write the notification message to different files to avoid race condition in `feature_notifications.py` (ken2812221)
838- #14306 appveyor: Move AppVeyor YAML to dot-file-style YAML (MitchellCash)
839- #14305 Enforce critical class instance attributes in functional tests, fix segwit test specificity (JustinTArthur)
840- #12246 Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled (luke-jr)
841- #14316 Exclude all tests with difference parameters in `--exclude` list (ken2812221)
842- #14381 Add missing call to `skip_if_no_cli()` (practicalswift)
843- #14389 travis: Set codespell version to avoid breakage (MarcoFalke)
844- #14398 Don't access out of bounds array index: array[sizeof(array)] (Empact)
845- #14419 Remove `rpc_zmq.py` (jnewbery)
846- #14241 appveyor: Script improvement (ken2812221)
847- #14413 Allow closed RPC handler in `assert_start_raises_init_error` (ken2812221)
848- #14324 Run more tests with wallet disabled (MarcoFalke)
849- #13649 Allow arguments to be forwarded to flake8 in lint-python.sh (jamesob)
850- #14465 Stop node before removing the notification file (ken2812221)
851- #14460 Improve 'CAmount' tests (hebasto)
852- #14456 forward timeouts properly in `send_blocks_and_test` (jamesob)
853- #14527 Revert "Make qt wallet test compatible with qt4" (MarcoFalke)
854- #14504 Show the progress of functional tests (isghe)
855- #14559 appveyor: Enable multiwallet tests (ken2812221)
856- #13515 travis: Enable qt for all jobs (ken2812221)
857- #14571 Test that nodes respond to `getdata` with `notfound` (MarcoFalke)
858- #14569 Print dots by default in functional tests (ken2812221)
859- #14631 Move deterministic address import to `setup_nodes` (jnewbery)
860- #14630 test: Remove travis specific code (MarcoFalke)
861- #14528 travis: Compile once on xenial (MarcoFalke)
862- #14092 Dry run `bench_bitcoin` as part `make check` to allow for quick identification of assertion/sanitizer failures in benchmarking code (practicalswift)
863- #14664 `example_test.py`: fixup coinbase height argument, derive number clearly (instagibbs)
864- #14522 Add invalid P2P message tests (jamesob)
865- #14619 Fix value display name in `test_runner` help text (merland)
866- #14672 Send fewer spam messages in `p2p_invalid_messages` (jamesob)
867- #14673 travis: Fail the ubsan travis build in case of newly introduced ubsan errors (practicalswift)
868- #14665 appveyor: Script improvement part II (ken2812221)
869- #14365 Add Python dead code linter (vulture) to Travis (practicalswift)
870- #14693 `test_node`: `get_mem_rss` fixups (MarcoFalke)
871- #14714 util.h: explicitly include required QString header (1Il1)
872- #14705 travis: Avoid timeout on verify-commits check (MarcoFalke)
873- #14770 travis: Do not specify sudo in `.travis` (scravy)
874- #14719 Check specific reject reasons in `feature_block` (MarcoFalke)
875- #14771 Add `BOOST_REQUIRE` to getters returning optional (MarcoFalke)
876- #14777 Add regtest for JSON-RPC batch calls (domob1812)
877- #14764 travis: Run thread sanitizer on unit tests (MarcoFalke)
878- #14400 Add Benchmark to test input de-duplication worst case (JeremyRubin)
879- #14812 Fix `p2p_invalid_messages` on macOS (jamesob)
880- #14813 Add `wallet_encryption` error tests (MarcoFalke)
881- #14820 Fix `descriptor_tests` not checking ToString output of public descriptors (ryanofsky)
882- #14794 Add AddressSanitizer (ASan) Travis build (practicalswift)
883- #14819 Bugfix: `test/functional/mempool_accept`: Ensure oversize transaction is actually oversize (luke-jr)
884- #14822 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke)
885- #14683 Better `combine_logs.py` behavior (jamesob)
886- #14231 travis: Save cache even when build or test fail (ken2812221)
887- #14816 Add CScriptNum decode python implementation in functional suite (instagibbs)
888- #14861 Modify `rpc_bind` to conform to #14532 behaviour (dongcarl)
889- #14864 Run scripted-diff in subshell (dongcarl)
890- #14795 Allow `test_runner` command line to receive parameters for each test (marcoagner)
891- #14788 Possible fix the permission error when the tests open the cookie file (ken2812221)
892- #14857 `wallet_keypool_topup.py`: Test for all keypool address types (instagibbs)
893- #14886 Refactor importmulti tests (jnewbery)
894- #14908 Removed implicit CTransaction constructor calls from tests and benchmarks (lucash-dev)
895- #14903 Handle ImportError explicitly, improve comparisons against None (daniel-s-ingram)
896- #14884 travis: Enforce python 3.4 support through linter (Sjors)
897- #14940 Add test for truncated pushdata script (MarcoFalke)
898- #14926 consensus: Check that final transactions are valid (MarcoFalke)
899- #14937 travis: Fix travis would always be green even if it fail (ken2812221)
900- #14953 Make `g_insecure_rand_ctx` `thread_local` (MarcoFalke)
901- #14931 mempool: Verify prioritization is dumped correctly (MarcoFalke)
902- #14935 Test for expected return values when calling functions returning a success code (practicalswift)
903- #14969 Fix `cuckoocache_tests` TSAN failure introduced in 14935 (practicalswift)
904- #14964 Fix race in `mempool_accept` (MarcoFalke)
905- #14829 travis: Enable functional tests in the threadsanitizer (tsan) build job (practicalswift)
906- #14985 Remove `thread_local` from `test_bitcoin` (MarcoFalke)
907- #15005 Bump timeout to run tests in travis thread sanitizer (MarcoFalke)
908- #15013 Avoid race in `p2p_timeouts` (MarcoFalke)
909- #14960 lint/format-strings: Correctly exclude escaped percent symbols (luke-jr)
910- #14930 pruning: Check that verifychain can be called when pruned (MarcoFalke)
911- #15022 Upgrade Travis OS to Xenial (gkrizek)
912- #14738 Fix running `wallet_listtransactions.py` individually through `test_runner.py` (kristapsk)
913- #15026 Rename `rpc_timewait` to `rpc_timeout` (MarcoFalke)
914- #15069 Fix `rpc_net.py` `pong` race condition (Empact)
915- #14790 Allow running `rpc_bind.py` --nonloopback test without IPv6 (kristapsk)
916- #14457 add invalid tx templates for use in functional tests (jamesob)
917- #14855 Correct ineffectual WithOrVersion from `transactions_tests` (Empact)
918- #15099 Use `std::vector` API for construction of test data (domob1812)
919- #15102 Run `invalid_txs.InputMissing` test in `feature_block` (MarcoFalke)
920- #15059 Add basic test for BIP34 (MarcoFalke)
921- #15108 Tidy up `wallet_importmulti.py` (amitiuttarwar)
922- #15164 Ignore shellcheck warning SC2236 (promag)
923- #15170 refactor/lint: Add ignored shellcheck suggestions to an array (koalaman)
924- #14958 Remove race between connecting and shutdown on separate connections (promag)
925- #15166 Pin shellcheck version (practicalswift)
926- #15196 Update all `subprocess.check_output` functions to be Python 3.4 compatible (gkrizek)
927- #15043 Build fuzz targets into seperate executables (MarcoFalke)
928- #15276 travis: Compile once on trusty (MarcoFalke)
929- #15246 Add tests for invalid message headers (MarcoFalke)
930- #15301 When testing with --usecli, unify RPC arg to cli arg conversion and handle dicts and lists (achow101)
931- #15247 Use wallet to retrieve raw transactions (MarcoFalke)
932- #15303 travis: Remove unused `functional_tests_config` (MarcoFalke)
933- #15330 Fix race in `p2p_invalid_messages` (MarcoFalke)
934- #15324 Make bloom tests deterministic (MarcoFalke)
935- #15328 travis: Revert "run extended tests once daily" (MarcoFalke)
936- #15327 Make test `updatecoins_simulation_test` deterministic (practicalswift)
937- #14519 add utility to easily profile node performance with perf (jamesob)
938- #15349 travis: Only exit early if compilation took longer than 30 min (MarcoFalke)
939- #15350 Drop RPC connection if --usecli (promag)
940- #15370 test: Remove unused --force option (MarcoFalke)
941- #14543 minor `p2p_sendheaders` fix of height in coinbase (instagibbs)
942- #13787 Test for Windows encoding issue (ken2812221)
943- #15378 Added missing tests for RPC wallet errors (benthecarman)
944- #15238 remove some magic mining constants in functional tests (instagibbs)
945- #15411 travis: Combine --disable-bip70 into existing job (MarcoFalke)
946- #15295 fuzz: Add `test/fuzz/test_runner.py` and run it in travis (MarcoFalke)
947- #15413 Add missing `cs_main` locks required when accessing pcoinsdbview, pcoinsTip or pblocktree (practicalswift)
948- #15399 fuzz: Script validation flags (MarcoFalke)
949- #15410 txindex: interrupt threadGroup before calling destructor (MarcoFalke)
950- #15397 Remove manual byte editing in `wallet_tx_clone` func test (instagibbs)
951- #15415 functional: allow custom cwd, use tmpdir as default (Sjors)
952- #15404 Remove `-txindex` to start nodes (amitiuttarwar)
953- #15439 remove `byte.hex()` to keep compatibility (AkioNak)
954- #15419 Always refresh cache to be out of ibd (MarcoFalke)
955- #15507 Bump timeout on tests that timeout on windows (MarcoFalke)
956- #15506 appveyor: fix cache issue and reduce dependencies build time (ken2812221)
957- #15485 add `rpc_misc.py`, mv test getmemoryinfo, add test mallocinfo (adamjonas)
958- #15321 Add `cs_main` lock annotations for mapBlockIndex (MarcoFalke)
959- #14128 lint: Make sure we read the command line inputs using UTF-8 decoding in python (ken2812221)
960- #14115 lint: Make all linters work under the default macos dev environment (build-osx.md) (practicalswift)
961- #15219 lint: Enable python linters via an array (Empact)
962
963### Platform support
964- #13866 utils: Use `_wfopen` and `_wfreopen` on windows (ken2812221)
965- #13886 utils: Run commands using UTF-8 string on windows (ken2812221)
966- #14192 utils: Convert `fs::filesystem_error` messages from local multibyte to UTF-8 on windows (ken2812221)
967- #13877 utils: Make fs::path::string() always return UTF-8 string on windows (ken2812221)
968- #13883 utils: Convert windows args to UTF-8 string (ken2812221)
969- #13878 utils: Add fstream wrapper to allow to pass unicode filename on windows (ken2812221)
970- #14426 utils: Fix broken windows filelock (ken2812221)
971- #14686 Fix windows build error if `--disable-bip70` (ken2812221)
972- #14922 windows: Set `_WIN32_WINNT` to 0x0601 (Windows 7) (ken2812221)
973- #13888 Call unicode API on Windows (ken2812221)
974- #15468 Use `fsbridge::ifstream` to fix Windows path issue (ken2812221)
975- #13734 Drop `boost::scoped_array` and use `wchar_t` API explicitly on Windows (ken2812221)
976- #13884 Enable bdb unicode support for Windows (ken2812221)
977
978### Miscellaneous
979- #13935 contrib: Adjust output to current test format (AkioNak)
980- #14097 validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (MarcoFalke)
981- #13724 contrib: Support ARM and RISC-V symbol check (ken2812221)
982- #13159 Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP) (practicalswift)
983- #14186 bitcoin-cli: don't translate command line options (HashUnlimited)
984- #14057 logging: Only log `using config file path_to_bitcoin.conf` message on startup if conf file exists (leishman)
985- #14164 Update univalue subtree (MarcoFalke)
986- #14272 init: Remove deprecated args from hidden args (MarcoFalke)
987- #14494 Error if # is used in rpcpassword in conf (MeshCollider)
988- #14742 Properly generate salt in rpcauth.py (dongcarl)
989- #14708 Warn unrecognised sections in the config file (AkioNak)
990- #14756 Improve rpcauth.py by using argparse and getpass modules (promag)
991- #14785 scripts: Fix detection of copyright holders (cornelius)
992- #14831 scripts: Use `#!/usr/bin/env bash` instead of `#!/bin/bash` (vim88)
993- #14869 Scripts: Add trusted key for samuel dobson (laanwj)
994- #14809 Tools: improve verify-commits.py script (jlopp)
995- #14624 Some simple improvements to the RNG code (sipa)
996- #14947 scripts: Remove python 2 import workarounds (practicalswift)
997- #15087 Error if rpcpassword contains hash in conf sections (MeshCollider)
998- #14433 Add checksum in gitian build scripts for ossl (TheCharlatan)
999- #15165 contrib: Allow use of github api authentication in github-merge (laanwj)
1000- #14409 utils and libraries: Make 'blocksdir' always net specific (hebasto)