READ THE CODE

Inside Bitcoin

The code behind the network, with room to understand it.

Stable release v32.1bitcoin/bitcoin · f0de87f04062 ↗3,020 source files · 47.5 MB stored on the server440 file guides

Release published 2026-10-28 · Snapshot fetched 2026-11-01. Latest stable release at fetch time; development branches and Git history are excluded. Only the selected code window and visible folders load here.

6,027 bytes · SHA-256 290d7e6413cfa12c… · View upstream ↗

1#!/usr/bin/env python3
2# Copyright (c) 2015-present The Bitcoin Core developers
3# Distributed under the MIT software license, see the accompanying
4# file COPYING or http://www.opensource.org/licenses/mit-license.php.
5"""Test BIP66 (DER SIG).
6
7Test the DERSIG soft-fork activation on regtest.
8"""
9
10from test_framework.blocktools import (
11    create_block,
12)
13from test_framework.messages import msg_block
14from test_framework.p2p import P2PInterface
15from test_framework.script import CScript
16from test_framework.test_framework import BitcoinTestFramework
17from test_framework.util import (
18    assert_equal,
19)
20from test_framework.wallet import (
21    MiniWallet,
22    MiniWalletMode,
23)
24
25
26# A canonical signature consists of:
27# <30> <total len> <02> <len R> <R> <02> <len S> <S> <hashtype>
28def unDERify(tx):
29    """
30    Make the signature in vin 0 of a tx non-DER-compliant,
31    by adding padding after the S-value.
32    """
33    scriptSig = CScript(tx.vin[0].scriptSig)
34    newscript = []
35    for i in scriptSig:
36        if (len(newscript) == 0):
37            newscript.append(i[0:-1] + b'\0' + i[-1:])
38        else:
39            newscript.append(i)
40    tx.vin[0].scriptSig = CScript(newscript)
41
42
43DERSIG_HEIGHT = 102
44
45
46class BIP66Test(BitcoinTestFramework):
47    def set_test_params(self):
48        self.num_nodes = 1
49        # whitelist peers to speed up tx relay / mempool sync
50        self.noban_tx_relay = True
51        self.extra_args = [[
52            f'-testactivationheight=dersig@{DERSIG_HEIGHT}',
53        ]]
54        self.setup_clean_chain = True
55        self.rpc_timeout = 240
56
57    def create_tx(self, input_txid):
58        utxo_to_spend = self.miniwallet.get_utxo(txid=input_txid, mark_as_spent=False)
59        return self.miniwallet.create_self_transfer(utxo_to_spend=utxo_to_spend)['tx']
60
61    def test_dersig_info(self, *, is_active):
62        assert_equal(self.nodes[0].getdeploymentinfo()['deployments']['bip66'],
63            {
64                "active": is_active,
65                "height": DERSIG_HEIGHT,
66                "type": "buried",
67            },
68        )
69
70    def run_test(self):
71        peer = self.nodes[0].add_p2p_connection(P2PInterface())
72        self.miniwallet = MiniWallet(self.nodes[0], mode=MiniWalletMode.RAW_P2PK)
73
74        self.test_dersig_info(is_active=False)
75
76        self.log.info("Mining %d blocks", DERSIG_HEIGHT - 2)
77        self.coinbase_txids = [self.nodes[0].getblock(b)['tx'][0] for b in self.generate(self.miniwallet, DERSIG_HEIGHT - 2)]
78
79        self.log.info("Test that a transaction with non-DER signature can still appear in a block")
80
81        spendtx = self.create_tx(self.coinbase_txids[0])
82        unDERify(spendtx)
83
84        tip = self.nodes[0].getbestblockhash()
85        block_time = self.nodes[0].getblockheader(tip)['mediantime'] + 1
86        block = create_block(int(tip, 16), height=DERSIG_HEIGHT - 1, ntime=block_time, txlist=[spendtx])
87        block.solve()
88
89        assert_equal(self.nodes[0].getblockcount(), DERSIG_HEIGHT - 2)
90        self.test_dersig_info(is_active=False)  # Not active as of current tip and next block does not need to obey rules
91        peer.send_and_ping(msg_block(block))
92        assert_equal(self.nodes[0].getblockcount(), DERSIG_HEIGHT - 1)
93        self.test_dersig_info(is_active=True)  # Not active as of current tip, but next block must obey rules
94        assert_equal(self.nodes[0].getbestblockhash(), block.hash_hex)
95
96        self.log.info("Test that blocks must now be at least version 3")
97        tip = block.hash_int
98        block_time += 1
99        block = create_block(tip, height=DERSIG_HEIGHT, ntime=block_time, version=2)
100        block.solve()
101
102        with self.nodes[0].assert_debug_log(expected_msgs=[f'{block.hash_hex}, bad-version(0x00000002)']):
103            peer.send_and_ping(msg_block(block))
104            assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
105            peer.sync_with_ping()
106
107        self.log.info("Test that transactions with non-DER signatures cannot appear in a block")
108        block.nVersion = 4
109
110        coin_txid = self.coinbase_txids[1]
111        spendtx = self.create_tx(coin_txid)
112        unDERify(spendtx)
113
114        # First we show that this tx is valid except for DERSIG by getting it
115        # rejected from the mempool for exactly that reason.
116        spendtx_txid = spendtx.txid_hex
117        spendtx_wtxid = spendtx.wtxid_hex
118        assert_equal(
119            [{
120                'txid': spendtx_txid,
121                'wtxid': spendtx_wtxid,
122                'allowed': False,
123                'reject-reason': 'mempool-script-verify-flag-failed (Non-canonical DER signature)',
124                'reject-details': 'mempool-script-verify-flag-failed (Non-canonical DER signature), ' +
125                                  f"input 0 of {spendtx_txid} (wtxid {spendtx_wtxid}), spending {coin_txid}:0"
126            }],
127            self.nodes[0].testmempoolaccept(rawtxs=[spendtx.serialize().hex()], maxfeerate=0),
128        )
129
130        # Now we verify that a block with this transaction is also invalid.
131        block.vtx.append(spendtx)
132        block.hashMerkleRoot = block.calc_merkle_root()
133        block.solve()
134
135        with self.nodes[0].assert_debug_log(expected_msgs=['Block validation error: block-script-verify-flag-failed (Non-canonical DER signature)']):
136            peer.send_and_ping(msg_block(block))
137            assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip)
138            peer.sync_with_ping()
139
140        self.log.info("Test that a block with a DERSIG-compliant transaction is accepted")
141        block.vtx[1] = self.create_tx(self.coinbase_txids[1])
142        block.hashMerkleRoot = block.calc_merkle_root()
143        block.solve()
144
145        self.test_dersig_info(is_active=True)  # Not active as of current tip, but next block must obey rules
146        peer.send_and_ping(msg_block(block))
147        self.test_dersig_info(is_active=True)  # Active as of current tip
148        assert_equal(self.nodes[0].getbestblockhash(), block.hash_hex)
149
150
151if __name__ == '__main__':
152    BIP66Test(__file__).main()
153

src/wallet/receive.cpp

src/wallet/coinselection.cpp

src/consensus/validation.h

src/primitives/transaction.cpp

src/script/descriptor.cpp

src/bitcoin-cli.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/init.cpp

src/crypto/sha256.cpp

src/consensus/merkle.h

src/consensus/tx_check.h

src/consensus/tx_verify.h

src/policy/feerate.h

src/policy/feerate.cpp

src/primitives/transaction_identifier.h

src/chainparamsbase.h

src/chainparamsbase.cpp

src/util/moneystr.cpp

src/crypto/ripemd160.h

src/crypto/sha1.h

src/crypto/sha512.h

src/crypto/hmac_sha256.h

src/crypto/hmac_sha512.h

src/crypto/hmac_sha256.cpp

src/crypto/hmac_sha512.cpp

src/crypto/hkdf_sha256_32.h

src/crypto/hkdf_sha256_32.cpp

src/support/cleanse.h

src/support/cleanse.cpp

src/crypto/siphash.cpp

src/crypto/muhash.h

src/crypto/chacha20.h

src/crypto/poly1305.h

src/crypto/chacha20poly1305.h

src/crypto/chacha20poly1305.cpp

src/util/chaintype.cpp

src/util/obfuscation.h

src/util/byte_units.h

src/util/overflow.h

src/blockencodings.cpp

src/net_permissions.cpp

src/policy/packages.cpp

src/policy/rbf.cpp

src/policy/truc_policy.cpp

src/policy/ephemeral_policy.cpp

src/policy/settings.cpp

src/policy/policy.cpp

src/node/transaction.cpp

src/node/coin.cpp

src/rpc/client.cpp

src/rpc/external_signer.cpp

src/rpc/request.cpp

src/rpc/server_util.cpp

src/rpc/fees.cpp

src/rpc/output_script.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/rawtransaction_util.h

src/rpc/register.h

src/rpc/request.h

src/rpc/server_util.h

src/rpc/protocol.h

src/rpc/server.h

src/rpc/signmessage.cpp

src/rpc/txoutproof.cpp

src/rpc/util.cpp

src/rpc/util.h

src/wallet/rpc/addresses.cpp

src/wallet/rpc/backup.cpp

src/wallet/rpc/coins.cpp

src/wallet/rpc/encrypt.cpp

src/wallet/rpc/signmessage.cpp

src/wallet/rpc/util.cpp

src/wallet/rpc/util.h

src/wallet/coincontrol.cpp

src/wallet/coincontrol.h

src/wallet/context.cpp

src/wallet/context.h

src/wallet/crypter.cpp

src/wallet/crypter.h

src/wallet/db.cpp

src/wallet/export.cpp

src/wallet/external_signer_scriptpubkeyman.cpp

src/wallet/rpc/spend.cpp

src/wallet/rpc/transactions.cpp

src/wallet/rpc/wallet.cpp

src/wallet/feebumper.cpp

src/wallet/feebumper.h

src/index/base.h

src/index/base.cpp

src/index/txindex.h

src/index/txindex.cpp

src/index/txindex_key.h

src/index/txospenderindex.h

src/index/txospenderindex.cpp

src/index/blockfilterindex.h

src/index/blockfilterindex.cpp

src/index/coinstatsindex.h

src/index/coinstatsindex.cpp

src/index/db_key.h

src/index/disktxpos.h

src/kernel/chain.cpp

src/kernel/chain.h

src/kernel/checks.cpp

src/kernel/checks.h

src/kernel/context.cpp

src/kernel/context.h

src/kernel/cs_main.cpp

src/kernel/cs_main.h

src/kernel/disconnected_transactions.cpp

src/kernel/disconnected_transactions.h

src/kernel/mempool_removal_reason.cpp

src/kernel/mempool_removal_reason.h

src/kernel/coinstats.cpp

src/kernel/coinstats.h

src/kernel/chainparams.cpp

src/kernel/chainparams.h

src/wallet/sqlite.cpp

src/wallet/sqlite.h

src/wallet/transaction.cpp

src/wallet/transaction.h

src/wallet/dump.cpp

src/wallet/dump.h

src/wallet/init.cpp

src/wallet/walletutil.cpp

src/wallet/walletutil.h

src/wallet/wallettool.cpp

src/wallet/wallettool.h

src/wallet/export.h

src/wallet/migrate.cpp

src/wallet/migrate.h

src/wallet/db.h

src/wallet/walletdb.cpp

src/wallet/interfaces.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/scriptpubkeyman.h

src/kernel/bitcoinkernel.cpp

src/kernel/bitcoinkernel.h

src/kernel/bitcoinkernel_wrapper.h

src/node/chainstate.cpp

src/node/chainstate.h

src/node/blockstorage.cpp

src/node/blockstorage.h

src/node/mempool_persist.cpp

src/node/mempool_persist.h

src/node/utxo_snapshot.cpp

src/node/utxo_snapshot.h

src/node/kernel_notifications.cpp

src/node/kernel_notifications.h

src/node/blockmanager_args.cpp

src/kernel/blockmanager_opts.h

src/util/expected.cpp

src/policy/settings.h

src/util/types.h

src/kernel/messagestartchars.h

src/kernel/warning.h

src/util/exception.h

src/common/license_info.h

src/node/coins_view_args.h

src/node/database_args.h

src/util/batchpriority.h

src/util/ui_change_type.h

src/node/coins_view_args.cpp

src/node/peerman_args.h

src/util/serfloat.h

src/node/blockmanager_args.h

src/node/database_args.cpp

src/util/overloaded.h

src/interfaces/types.h

src/node/chainstatemanager_args.h

src/node/minisketchwrapper.h

src/util/macros.h

src/util/syserror.h

src/common/run_command.h

src/util/bytevectorhash.cpp

src/node/mempool_persist_args.cpp

src/util/exec.h

src/util/rbf.h

src/crypto/hex_base.h

src/node/mempool_persist_args.h

src/interfaces/echo.h

src/util/any.h

src/util/batchpriority.cpp

src/util/threadnames.h

src/node/coin.h

src/node/mempool_args.h

src/util/asmap.h

src/util/bytevectorhash.h

src/node/context.cpp

src/util/insert.h

src/util/readwritefile.h

src/node/peerman_args.cpp

src/node/interface_ui.cpp

src/interfaces/handler.h

src/node/mining_args.h

src/util/hasher.cpp

src/common/init.h

src/kernel/mempool_limits.h

src/common/system.h

src/crypto/sha3.h

src/util/threadinterrupt.cpp

src/node/protocol_version.h

src/util/exception.cpp

src/common/messages.h

src/node/connection_types.cpp

src/util/bip32.h

src/common/license_info.cpp

src/util/stdmutex.h

src/common/run_command.cpp

src/util/check.cpp

src/util/golombrice.h

src/node/types.h

src/node/timeoffsets.h

src/util/readwritefile.cpp

src/util/fastrange.h

src/util/signalinterrupt.h

src/util/task_runner.h

src/util/syserror.cpp

src/common/interfaces.cpp

src/common/types.h

src/util/threadinterrupt.h

src/kernel/chainstatemanager_opts.h

src/node/psbt.h

src/policy/ephemeral_policy.h

src/util/trace.h

src/common/url.cpp

src/kernel/mempool_options.h

src/util/serfloat.cpp

src/kernel/notifications_interface.h

src/node/timeoffsets.cpp

src/node/warnings.cpp

src/util/hash_type.h

src/crypto/hex_base.cpp

src/node/eviction.h

src/util/tokenbucket.h

src/crypto/aes.h

src/common/pcp.h

src/util/feefrac.cpp

src/node/transaction.h

src/util/threadnames.cpp

src/common/signmessage.h

src/util/exec.cpp

src/util/signalinterrupt.cpp

src/clientversion.cpp

src/common/signmessage.cpp

src/compat/assumptions.h

src/compat/byteswap.h

src/deploymentinfo.cpp

src/deploymentinfo.h

src/deploymentstatus.cpp

src/deploymentstatus.h

src/dummywallet.cpp

src/external_signer.h

src/init/bitcoin-gui.cpp

src/init/bitcoin-node.cpp

src/init/bitcoin-qt.cpp

src/init/bitcoin-wallet.cpp

src/init/bitcoind.cpp

src/init/common.h

src/interfaces/init.h

src/interfaces/ipc.h

src/key_io.h

src/logging/categories.h

src/logging/timer.h

src/mapport.h

src/musig.h

src/net_permissions.h

src/netgroup.h

src/netmessagemaker.h

src/node/chainstatemanager_args.cpp

src/node/connection_types.h

src/node/context.h

src/node/interface_ui.h

src/node/mempool_args.cpp

src/node/mining_args.cpp

src/node/minisketchwrapper.cpp

src/node/txreconciliation.h

src/policy/fees/estimator_args.cpp

src/policy/fees/estimator_args.h

src/policy/fees/estimator_man.cpp

src/policy/fees/estimator_man.h

src/policy/packages.h

src/policy/rbf.h

src/policy/truc_policy.h

src/pow.h

src/primitives/block.cpp

src/randomenv.h

src/rest.h

src/script/keyorigin.h

src/script/parsing.cpp

src/script/parsing.h

src/script/script_error.h

src/script/sigcache.cpp

src/script/sigcache.h

src/script/solver.h

src/script/verify_flags.h

src/semaphore_grant.h

src/signet.h

src/span.h

src/support/allocators/secure.h

src/support/allocators/zeroafterfree.h

src/util/tokenpipe.cpp

src/util/translation.h

src/util/vector.h

src/versionbits.h

src/versionbits_impl.h

src/wallet/external_signer_scriptpubkeyman.h

src/wallet/fees.h

src/wallet/load.h

src/wallet/receive.h

src/wallet/rpc/wallet.h

src/wallet/types.h

src/walletinitinterface.h

src/zmq/zmqabstractnotifier.cpp

Independent explanations by MyBitcoinExplorer. Not affiliated with or endorsed by Bitcoin Core. Guides are educational and do not replace the source or its tests.

Bitcoin Core source © its contributors, distributed under the MIT license. Original notices and bundled third-party licenses are retained in the source tree.