READ THE CODE

Inside Bitcoin

The code behind the network, with room to understand it.

Stable release v32.1bitcoin/bitcoin · f0de87f04062 ↗3,020 source files · 47.5 MB stored on the server440 file guides

Release published 2026-10-28 · Snapshot fetched 2026-11-01. Latest stable release at fetch time; development branches and Git history are excluded. Only the selected code window and visible folders load here.

11,124 bytes · SHA-256 3599db3c80928023… · View upstream ↗

1#!/usr/bin/env python3
2# Copyright (c) 2014-present The Bitcoin Core developers
3# Distributed under the MIT software license, see the accompanying
4# file COPYING or http://www.opensource.org/licenses/mit-license.php.
5"""Test the wallet accounts properly when there are cloned transactions with malleated scriptsigs."""
6
7from test_framework.test_framework import BitcoinTestFramework
8from test_framework.util import (
9    assert_equal,
10    assert_not_equal,
11    assert_raises_rpc_error,
12)
13from test_framework.messages import (
14    COIN,
15    tx_from_hex,
16)
17
18
19class TxnMallTest(BitcoinTestFramework):
20    def set_test_params(self):
21        self.num_nodes = 3
22        self.extra_args = [[] for i in range(self.num_nodes)]
23
24    def skip_test_if_missing_module(self):
25        self.skip_if_no_wallet()
26
27    def add_options(self, parser):
28        parser.add_argument("--mineblock", dest="mine_block", default=False, action="store_true",
29                            help="Test double-spend of 1-confirmed transaction")
30        parser.add_argument("--segwit", dest="segwit", default=False, action="store_true",
31                            help="Test behaviour with SegWit txn (which should fail)")
32
33    def setup_network(self):
34        # Start with split network:
35        super().setup_network()
36        self.disconnect_nodes(1, 2)
37
38    def spend_utxo(self, utxo, outputs):
39        inputs = [utxo]
40        tx = self.nodes[0].createrawtransaction(inputs, outputs)
41        tx = self.nodes[0].fundrawtransaction(tx, fee_rate=100)
42        tx = self.nodes[0].signrawtransactionwithwallet(tx['hex'])
43        return self.nodes[0].sendrawtransaction(tx['hex'])
44
45    def run_test(self):
46        if self.options.segwit:
47            output_type = "p2sh-segwit"
48        else:
49            output_type = "legacy"
50
51        # All nodes should start with 1,250 BTC:
52        starting_balance = 1250
53        for i in range(3):
54            assert_equal(self.nodes[i].getbalance(), starting_balance)
55
56        node0_address1 = self.nodes[0].getnewaddress(address_type=output_type)
57        node0_utxo1 = self.create_outpoints(self.nodes[0], outputs=[{node0_address1: 1219}])[0]
58        node0_tx1 = self.nodes[0].gettransaction(node0_utxo1['txid'])
59        self.nodes[0].lockunspent(False, [node0_utxo1])
60
61        node0_address2 = self.nodes[0].getnewaddress(address_type=output_type)
62        node0_utxo2 = self.create_outpoints(self.nodes[0], outputs=[{node0_address2: 29}])[0]
63        node0_tx2 = self.nodes[0].gettransaction(node0_utxo2['txid'])
64
65        assert_equal(self.nodes[0].getbalance(),
66                     starting_balance + node0_tx1["fee"] + node0_tx2["fee"])
67
68        # Coins are sent to node1_address
69        node1_address = self.nodes[1].getnewaddress()
70
71        # Send tx1, and another transaction tx2 that won't be cloned
72        txid1 = self.spend_utxo(node0_utxo1, {node1_address: 40})
73        txid2 = self.spend_utxo(node0_utxo2, {node1_address: 20})
74
75        # Construct a clone of tx1, to be malleated
76        rawtx1 = self.nodes[0].getrawtransaction(txid1, 1)
77        clone_inputs = [{"txid": rawtx1["vin"][0]["txid"], "vout": rawtx1["vin"][0]["vout"], "sequence": rawtx1["vin"][0]["sequence"]}]
78        clone_outputs = {rawtx1["vout"][0]["scriptPubKey"]["address"]: rawtx1["vout"][0]["value"],
79                         rawtx1["vout"][1]["scriptPubKey"]["address"]: rawtx1["vout"][1]["value"]}
80        clone_locktime = rawtx1["locktime"]
81        clone_raw = self.nodes[0].createrawtransaction(clone_inputs, clone_outputs, clone_locktime)
82
83        # createrawtransaction randomizes the order of its outputs, so swap them if necessary.
84        clone_tx = tx_from_hex(clone_raw)
85        if (rawtx1["vout"][0]["value"] == 40 and clone_tx.vout[0].nValue != 40*COIN or rawtx1["vout"][0]["value"] != 40 and clone_tx.vout[0].nValue == 40*COIN):
86            (clone_tx.vout[0], clone_tx.vout[1]) = (clone_tx.vout[1], clone_tx.vout[0])
87
88        # Use a different signature hash type to sign.  This creates an equivalent but malleated clone.
89        # Don't send the clone anywhere yet
90        tx1_clone = self.nodes[0].signrawtransactionwithwallet(clone_tx.serialize().hex(), None, "ALL|ANYONECANPAY")
91        assert_equal(tx1_clone["complete"], True)
92
93        # Have node0 mine a block, if requested:
94        if (self.options.mine_block):
95            self.generate(self.nodes[0], 1, sync_fun=lambda: self.sync_blocks(self.nodes[0:2]))
96
97        tx1 = self.nodes[0].gettransaction(txid1)
98        tx2 = self.nodes[0].gettransaction(txid2)
99
100        # Node0's balance should be starting balance, plus 50BTC for another
101        # matured block, minus tx1 and tx2 amounts, and minus transaction fees:
102        expected = starting_balance + node0_tx1["fee"] + node0_tx2["fee"]
103        if self.options.mine_block:
104            expected += 50
105        expected += tx1["amount"] + tx1["fee"]
106        expected += tx2["amount"] + tx2["fee"]
107        assert_equal(self.nodes[0].getbalance(), expected)
108
109        if self.options.mine_block:
110            assert_equal(tx1["confirmations"], 1)
111            assert_equal(tx2["confirmations"], 1)
112        else:
113            assert_equal(tx1["confirmations"], 0)
114            assert_equal(tx2["confirmations"], 0)
115
116        # Send clone and its parent to miner
117        self.nodes[2].sendrawtransaction(node0_tx1["hex"])
118        txid1_clone = self.nodes[2].sendrawtransaction(tx1_clone["hex"])
119        if self.options.segwit:
120            assert_equal(txid1, txid1_clone)
121            return
122
123        # ... mine a block...
124        self.generate(self.nodes[2], 1, sync_fun=self.no_op)
125
126        # Reconnect the split network, and sync chain:
127        self.connect_nodes(1, 2)
128        self.nodes[2].sendrawtransaction(node0_tx2["hex"])
129        self.nodes[2].sendrawtransaction(tx2["hex"])
130        self.generate(self.nodes[2], 1)  # Mine another block to make sure we sync
131
132        # Re-fetch transaction info:
133        tx1 = self.nodes[0].gettransaction(txid1)
134        tx1_clone = self.nodes[0].gettransaction(txid1_clone)
135        tx2 = self.nodes[0].gettransaction(txid2)
136
137        # Verify expected confirmations
138        assert_equal(tx1["confirmations"], -2)
139        assert_equal(tx1_clone["confirmations"], 2)
140        assert_equal(tx2["confirmations"], 1)
141
142        # Check node0's total balance; should be same as before the clone, + 100 BTC for 2 matured,
143        # less possible orphaned matured subsidy
144        expected += 100
145        if (self.options.mine_block):
146            expected -= 50
147        assert_equal(self.nodes[0].getbalance(), expected)
148
149        self.test_malleated_metadata_synced()
150        self.test_malleated_rbf_metadata_synced()
151
152    def malleate_tx(self, wallet, txid):
153        rawtx = wallet.getrawtransaction(txid)
154        tx = tx_from_hex(rawtx)
155        for txin in tx.vin:
156            txin.scriptSig = b""
157        for wit in tx.wit.vtxinwit:
158            wit.scriptWitness.stack.clear()
159        unsigned_tx = tx.serialize_without_witness().hex()
160
161        # malleate the tx by signing with a different sighash
162        malleated_tx = wallet.signrawtransactionwithwallet(hexstring=unsigned_tx, sighashtype="ALL|ANYONECANPAY")["hex"]
163        malleated_txid = wallet.decoderawtransaction(malleated_tx)["txid"]
164        assert_not_equal(malleated_txid, txid)
165        return malleated_tx, malleated_txid
166
167
168    def test_malleated_metadata_synced(self):
169        self.log.info("Test malleated tx has copied user provided metadata")
170        self.nodes[0].createwallet("metadata_clone")
171        wallet = self.nodes[0].get_wallet_rpc("metadata_clone")
172        def_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
173
174        # Make non-segwit UTXOs that can be malleated. Smaller than the spending amount
175        # to create multiple inputs.
176        for _ in range(6):
177            def_wallet.sendtoaddress(wallet.getnewaddress(address_type="legacy"), 0.5)
178
179        self.generate(self.nodes[0], 1)
180
181        # Bumping either should prevent the other from being bumped as well
182        for bump_malleated in [False, True]:
183            original_txid = wallet.sendtoaddress(def_wallet.getnewaddress(), 0.9, comment="testing", fee_rate=1)
184            malleated_tx, malleated_txid = self.malleate_tx(wallet, original_txid)
185
186            blockhash = self.generateblock(self.nodes[0], def_wallet.getnewaddress(), [malleated_tx])["hash"]
187
188            assert_equal(wallet.gettransaction(malleated_txid)["comment"], "testing")
189
190            # Check synced comment was written to disk
191            wallet.unloadwallet()
192            self.nodes[0].loadwallet("metadata_clone")
193            assert_equal(wallet.gettransaction(malleated_txid)["comment"], "testing")
194
195            # Put the malleated back into the mempol by invalidating the block
196            self.nodes[0].invalidateblock(blockhash)
197
198            if bump_malleated:
199                to_bump = malleated_txid
200                other_bump = original_txid
201            else:
202                to_bump = original_txid
203                other_bump = malleated_txid
204
205            bumped = wallet.bumpfee(to_bump, fee_rate=10)
206
207            def check_metadata():
208                original_txinfo = wallet.gettransaction(original_txid)
209                malleated_txinfo = wallet.gettransaction(malleated_txid)
210                assert_equal(original_txinfo["replaced_by_txid"], bumped["txid"])
211                assert_equal(malleated_txinfo["replaced_by_txid"], bumped["txid"])
212
213                assert_raises_rpc_error(-4, f"Cannot bump transaction {other_bump} which was already bumped by transaction", wallet.bumpfee, other_bump, fee_rate=20)
214
215            check_metadata()
216
217            # Check persistence
218            wallet.unloadwallet()
219            self.nodes[0].loadwallet("metadata_clone")
220
221            check_metadata()
222
223            self.nodes[0].reconsiderblock(blockhash)
224
225    def test_malleated_rbf_metadata_synced(self):
226        self.log.info("Test malleation of a rbf has copied user provided and replacement metadata")
227        self.nodes[0].createwallet("rbf_metadata_clone")
228        wallet = self.nodes[0].get_wallet_rpc("rbf_metadata_clone")
229        def_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
230
231        def_wallet.sendtoaddress(wallet.getnewaddress(address_type="legacy"), 1)
232
233        self.generate(self.nodes[0], 1)
234
235        orig_txid = wallet.sendtoaddress(def_wallet.getnewaddress(), 0.9999, comment="testing")
236        txid = wallet.bumpfee(orig_txid)["txid"]
237        malleated_tx, malleated_txid = self.malleate_tx(wallet, txid)
238
239        self.generateblock(self.nodes[0], def_wallet.getnewaddress(), [malleated_tx])
240
241        txinfo = wallet.gettransaction(malleated_txid)
242        assert_equal(txinfo["comment"], "testing")
243        assert_equal(txinfo["replaces_txid"], orig_txid)
244
245        # Synced metadata must survive a reload
246        wallet.unloadwallet()
247        self.nodes[0].loadwallet("rbf_metadata_clone")
248        txinfo = wallet.gettransaction(malleated_txid)
249        assert_equal(txinfo["comment"], "testing")
250        assert_equal(txinfo["replaces_txid"], orig_txid)

src/wallet/receive.cpp

src/wallet/coinselection.cpp

src/consensus/validation.h

src/primitives/transaction.cpp

src/script/descriptor.cpp

src/bitcoin-cli.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/init.cpp

src/crypto/sha256.cpp

src/consensus/merkle.h

src/consensus/tx_check.h

src/consensus/tx_verify.h

src/policy/feerate.h

src/policy/feerate.cpp

src/primitives/transaction_identifier.h

src/chainparamsbase.h

src/chainparamsbase.cpp

src/util/moneystr.cpp

src/crypto/ripemd160.h

src/crypto/sha1.h

src/crypto/sha512.h

src/crypto/hmac_sha256.h

src/crypto/hmac_sha512.h

src/crypto/hmac_sha256.cpp

src/crypto/hmac_sha512.cpp

src/crypto/hkdf_sha256_32.h

src/crypto/hkdf_sha256_32.cpp

src/support/cleanse.h

src/support/cleanse.cpp

src/crypto/siphash.cpp

src/crypto/muhash.h

src/crypto/chacha20.h

src/crypto/poly1305.h

src/crypto/chacha20poly1305.h

src/crypto/chacha20poly1305.cpp

src/util/chaintype.cpp

src/util/obfuscation.h

src/util/byte_units.h

src/util/overflow.h

src/blockencodings.cpp

src/net_permissions.cpp

src/policy/packages.cpp

src/policy/rbf.cpp

src/policy/truc_policy.cpp

src/policy/ephemeral_policy.cpp

src/policy/settings.cpp

src/policy/policy.cpp

src/node/transaction.cpp

src/node/coin.cpp

src/rpc/client.cpp

src/rpc/external_signer.cpp

src/rpc/request.cpp

src/rpc/server_util.cpp

src/rpc/fees.cpp

src/rpc/output_script.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/rawtransaction_util.h

src/rpc/register.h

src/rpc/request.h

src/rpc/server_util.h

src/rpc/protocol.h

src/rpc/server.h

src/rpc/signmessage.cpp

src/rpc/txoutproof.cpp

src/rpc/util.cpp

src/rpc/util.h

src/wallet/rpc/addresses.cpp

src/wallet/rpc/backup.cpp

src/wallet/rpc/coins.cpp

src/wallet/rpc/encrypt.cpp

src/wallet/rpc/signmessage.cpp

src/wallet/rpc/util.cpp

src/wallet/rpc/util.h

src/wallet/coincontrol.cpp

src/wallet/coincontrol.h

src/wallet/context.cpp

src/wallet/context.h

src/wallet/crypter.cpp

src/wallet/crypter.h

src/wallet/db.cpp

src/wallet/export.cpp

src/wallet/external_signer_scriptpubkeyman.cpp

src/wallet/rpc/spend.cpp

src/wallet/rpc/transactions.cpp

src/wallet/rpc/wallet.cpp

src/wallet/feebumper.cpp

src/wallet/feebumper.h

src/index/base.h

src/index/base.cpp

src/index/txindex.h

src/index/txindex.cpp

src/index/txindex_key.h

src/index/txospenderindex.h

src/index/txospenderindex.cpp

src/index/blockfilterindex.h

src/index/blockfilterindex.cpp

src/index/coinstatsindex.h

src/index/coinstatsindex.cpp

src/index/db_key.h

src/index/disktxpos.h

src/kernel/chain.cpp

src/kernel/chain.h

src/kernel/checks.cpp

src/kernel/checks.h

src/kernel/context.cpp

src/kernel/context.h

src/kernel/cs_main.cpp

src/kernel/cs_main.h

src/kernel/disconnected_transactions.cpp

src/kernel/disconnected_transactions.h

src/kernel/mempool_removal_reason.cpp

src/kernel/mempool_removal_reason.h

src/kernel/coinstats.cpp

src/kernel/coinstats.h

src/kernel/chainparams.cpp

src/kernel/chainparams.h

src/wallet/sqlite.cpp

src/wallet/sqlite.h

src/wallet/transaction.cpp

src/wallet/transaction.h

src/wallet/dump.cpp

src/wallet/dump.h

src/wallet/init.cpp

src/wallet/walletutil.cpp

src/wallet/walletutil.h

src/wallet/wallettool.cpp

src/wallet/wallettool.h

src/wallet/export.h

src/wallet/migrate.cpp

src/wallet/migrate.h

src/wallet/db.h

src/wallet/walletdb.cpp

src/wallet/interfaces.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/scriptpubkeyman.h

src/kernel/bitcoinkernel.cpp

src/kernel/bitcoinkernel.h

src/kernel/bitcoinkernel_wrapper.h

src/node/chainstate.cpp

src/node/chainstate.h

src/node/blockstorage.cpp

src/node/blockstorage.h

src/node/mempool_persist.cpp

src/node/mempool_persist.h

src/node/utxo_snapshot.cpp

src/node/utxo_snapshot.h

src/node/kernel_notifications.cpp

src/node/kernel_notifications.h

src/node/blockmanager_args.cpp

src/kernel/blockmanager_opts.h

src/util/expected.cpp

src/policy/settings.h

src/util/types.h

src/kernel/messagestartchars.h

src/kernel/warning.h

src/util/exception.h

src/common/license_info.h

src/node/coins_view_args.h

src/node/database_args.h

src/util/batchpriority.h

src/util/ui_change_type.h

src/node/coins_view_args.cpp

src/node/peerman_args.h

src/util/serfloat.h

src/node/blockmanager_args.h

src/node/database_args.cpp

src/util/overloaded.h

src/interfaces/types.h

src/node/chainstatemanager_args.h

src/node/minisketchwrapper.h

src/util/macros.h

src/util/syserror.h

src/common/run_command.h

src/util/bytevectorhash.cpp

src/node/mempool_persist_args.cpp

src/util/exec.h

src/util/rbf.h

src/crypto/hex_base.h

src/node/mempool_persist_args.h

src/interfaces/echo.h

src/util/any.h

src/util/batchpriority.cpp

src/util/threadnames.h

src/node/coin.h

src/node/mempool_args.h

src/util/asmap.h

src/util/bytevectorhash.h

src/node/context.cpp

src/util/insert.h

src/util/readwritefile.h

src/node/peerman_args.cpp

src/node/interface_ui.cpp

src/interfaces/handler.h

src/node/mining_args.h

src/util/hasher.cpp

src/common/init.h

src/kernel/mempool_limits.h

src/common/system.h

src/crypto/sha3.h

src/util/threadinterrupt.cpp

src/node/protocol_version.h

src/util/exception.cpp

src/common/messages.h

src/node/connection_types.cpp

src/util/bip32.h

src/common/license_info.cpp

src/util/stdmutex.h

src/common/run_command.cpp

src/util/check.cpp

src/util/golombrice.h

src/node/types.h

src/node/timeoffsets.h

src/util/readwritefile.cpp

src/util/fastrange.h

src/util/signalinterrupt.h

src/util/task_runner.h

src/util/syserror.cpp

src/common/interfaces.cpp

src/common/types.h

src/util/threadinterrupt.h

src/kernel/chainstatemanager_opts.h

src/node/psbt.h

src/policy/ephemeral_policy.h

src/util/trace.h

src/common/url.cpp

src/kernel/mempool_options.h

src/util/serfloat.cpp

src/kernel/notifications_interface.h

src/node/timeoffsets.cpp

src/node/warnings.cpp

src/util/hash_type.h

src/crypto/hex_base.cpp

src/node/eviction.h

src/util/tokenbucket.h

src/crypto/aes.h

src/common/pcp.h

src/util/feefrac.cpp

src/node/transaction.h

src/util/threadnames.cpp

src/common/signmessage.h

src/util/exec.cpp

src/util/signalinterrupt.cpp

src/clientversion.cpp

src/common/signmessage.cpp

src/compat/assumptions.h

src/compat/byteswap.h

src/deploymentinfo.cpp

src/deploymentinfo.h

src/deploymentstatus.cpp

src/deploymentstatus.h

src/dummywallet.cpp

src/external_signer.h

src/init/bitcoin-gui.cpp

src/init/bitcoin-node.cpp

src/init/bitcoin-qt.cpp

src/init/bitcoin-wallet.cpp

src/init/bitcoind.cpp

src/init/common.h

src/interfaces/init.h

src/interfaces/ipc.h

src/key_io.h

src/logging/categories.h

src/logging/timer.h

src/mapport.h

src/musig.h

src/net_permissions.h

src/netgroup.h

src/netmessagemaker.h

src/node/chainstatemanager_args.cpp

src/node/connection_types.h

src/node/context.h

src/node/interface_ui.h

src/node/mempool_args.cpp

src/node/mining_args.cpp

src/node/minisketchwrapper.cpp

src/node/txreconciliation.h

src/policy/fees/estimator_args.cpp

src/policy/fees/estimator_args.h

src/policy/fees/estimator_man.cpp

src/policy/fees/estimator_man.h

src/policy/packages.h

src/policy/rbf.h

src/policy/truc_policy.h

src/pow.h

src/primitives/block.cpp

src/randomenv.h

src/rest.h

src/script/keyorigin.h

src/script/parsing.cpp

src/script/parsing.h

src/script/script_error.h

src/script/sigcache.cpp

src/script/sigcache.h

src/script/solver.h

src/script/verify_flags.h

src/semaphore_grant.h

src/signet.h

src/span.h

src/support/allocators/secure.h

src/support/allocators/zeroafterfree.h

src/util/tokenpipe.cpp

src/util/translation.h

src/util/vector.h

src/versionbits.h

src/versionbits_impl.h

src/wallet/external_signer_scriptpubkeyman.h

src/wallet/fees.h

src/wallet/load.h

src/wallet/receive.h

src/wallet/rpc/wallet.h

src/wallet/types.h

src/walletinitinterface.h

src/zmq/zmqabstractnotifier.cpp

Independent explanations by MyBitcoinExplorer. Not affiliated with or endorsed by Bitcoin Core. Guides are educational and do not replace the source or its tests.

Bitcoin Core source © its contributors, distributed under the MIT license. Original notices and bundled third-party licenses are retained in the source tree.