READ THE CODE

Inside Bitcoin

The code behind the network, with room to understand it.

Stable release v32.1bitcoin/bitcoin · f0de87f04062 ↗3,020 source files · 47.5 MB stored on the server440 file guides

Release published 2026-10-28 · Snapshot fetched 2026-11-01. Latest stable release at fetch time; development branches and Git history are excluded. Only the selected code window and visible folders load here.

14,118 bytes · SHA-256 b179540f278320e3… · View upstream ↗

1#!/usr/bin/env python3
2# Copyright (c) 2015-present The Bitcoin Core developers
3# Distributed under the MIT software license, see the accompanying
4# file COPYING or http://www.opensource.org/licenses/mit-license.php.
5"""Test transaction signing using the signrawtransactionwithwallet RPC."""
6
7from test_framework.blocktools import (
8    COINBASE_MATURITY,
9)
10from test_framework.address import (
11    script_to_p2wsh,
12)
13from test_framework.test_framework import BitcoinTestFramework
14from test_framework.util import (
15    assert_equal,
16    assert_raises_rpc_error,
17)
18from test_framework.messages import (
19    CTxInWitness,
20    tx_from_hex,
21)
22from test_framework.script import (
23    CScript,
24    OP_CHECKLOCKTIMEVERIFY,
25    OP_CHECKSEQUENCEVERIFY,
26    OP_DROP,
27    OP_TRUE,
28)
29
30from decimal import (
31    Decimal,
32    getcontext,
33)
34
35
36RAW_TX = '020000000156b958f78e3f24e0b2f4e4db1255426b0902027cb37e3ddadb52e37c3557dddb0000000000ffffffff01c0a6b929010000001600149a2ee8c77140a053f36018ac8124a6ececc1668a00000000'
37
38
39class SignRawTransactionWithWalletTest(BitcoinTestFramework):
40    def set_test_params(self):
41        self.setup_clean_chain = True
42        self.num_nodes = 2
43
44    def skip_test_if_missing_module(self):
45        self.skip_if_no_wallet()
46
47    def test_with_lock_outputs(self):
48        self.log.info("Test correct error reporting when trying to sign a locked output")
49        self.nodes[0].encryptwallet("password")
50        assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].signrawtransactionwithwallet, RAW_TX)
51        self.nodes[0].walletpassphrase("password", 9999)
52
53    def test_with_invalid_sighashtype(self):
54        self.log.info("Test signrawtransactionwithwallet raises if an invalid sighashtype is passed")
55        assert_raises_rpc_error(-8, "'all' is not a valid sighash parameter.", self.nodes[0].signrawtransactionwithwallet, hexstring=RAW_TX, sighashtype="all")
56
57    def script_verification_error_test(self):
58        """Create and sign a raw transaction with valid (vin 0), invalid (vin 1) and one missing (vin 2) input script.
59
60        Expected results:
61
62        3) The transaction has no complete set of signatures
63        4) Two script verification errors occurred
64        5) Script verification errors have certain properties ("txid", "vout", "scriptSig", "sequence", "error")
65        6) The verification errors refer to the invalid (vin 1) and missing input (vin 2)"""
66        self.log.info("Test script verification errors")
67        privKeys = ['cUeKHd5orzT3mz8P9pxyREHfsWtVfgsfDjiZZBcjUBAaGk1BTj7N']
68
69        inputs = [
70            # Valid pay-to-pubkey script
71            {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0},
72            # Invalid script
73            {'txid': '5b8673686910442c644b1f4993d8f7753c7c8fcb5c87ee40d56eaeef25204547', 'vout': 7},
74            # Missing scriptPubKey
75            {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 1},
76        ]
77
78        scripts = [
79            # Valid pay-to-pubkey script
80            {'txid': '9b907ef1e3c26fc71fe4a4b3580bc75264112f95050014157059c736f0202e71', 'vout': 0,
81             'scriptPubKey': '76a91460baa0f494b38ce3c940dea67f3804dc52d1fb9488ac'},
82            # Invalid script
83            {'txid': '5b8673686910442c644b1f4993d8f7753c7c8fcb5c87ee40d56eaeef25204547', 'vout': 7,
84             'scriptPubKey': 'badbadbadbad'}
85        ]
86
87        outputs = {'mpLQjfK79b7CCV4VMJWEWAj5Mpx8Up5zxB': 0.1}
88
89        rawTx = self.nodes[0].createrawtransaction(inputs, outputs)
90
91        # Make sure decoderawtransaction is at least marginally sane
92        decodedRawTx = self.nodes[0].decoderawtransaction(rawTx)
93        for i, inp in enumerate(inputs):
94            assert_equal(decodedRawTx["vin"][i]["txid"], inp["txid"])
95            assert_equal(decodedRawTx["vin"][i]["vout"], inp["vout"])
96
97        # Make sure decoderawtransaction throws if there is extra data
98        assert_raises_rpc_error(-22, "TX decode failed", self.nodes[0].decoderawtransaction, rawTx + "00")
99
100        rawTxSigned = self.nodes[0].signrawtransactionwithkey(rawTx, privKeys, scripts)
101
102        # 3) The transaction has no complete set of signatures
103        assert not rawTxSigned['complete']
104
105        # 4) Two script verification errors occurred
106        assert 'errors' in rawTxSigned
107        assert_equal(len(rawTxSigned['errors']), 2)
108
109        # 5) Script verification errors have certain properties
110        assert 'txid' in rawTxSigned['errors'][0]
111        assert 'vout' in rawTxSigned['errors'][0]
112        assert 'witness' in rawTxSigned['errors'][0]
113        assert 'scriptSig' in rawTxSigned['errors'][0]
114        assert 'sequence' in rawTxSigned['errors'][0]
115        assert 'error' in rawTxSigned['errors'][0]
116
117        # 6) The verification errors refer to the invalid (vin 1) and missing input (vin 2)
118        assert_equal(rawTxSigned['errors'][0]['txid'], inputs[1]['txid'])
119        assert_equal(rawTxSigned['errors'][0]['vout'], inputs[1]['vout'])
120        assert_equal(rawTxSigned['errors'][1]['txid'], inputs[2]['txid'])
121        assert_equal(rawTxSigned['errors'][1]['vout'], inputs[2]['vout'])
122        assert not rawTxSigned['errors'][0]['witness']
123
124        # Now test signing failure for transaction with input witnesses
125        p2wpkh_raw_tx = "01000000000102fff7f7881a8099afa6940d42d1e7f6362bec38171ea3edf433541db4e4ad969f00000000494830450221008b9d1dc26ba6a9cb62127b02742fa9d754cd3bebf337f7a55d114c8e5cdd30be022040529b194ba3f9281a99f2b1c0a19c0489bc22ede944ccf4ecbab4cc618ef3ed01eeffffffef51e1b804cc89d182d279655c3aa89e815b1b309fe287d9b2b55d57b90ec68a0100000000ffffffff02202cb206000000001976a9148280b37df378db99f66f85c95a783a76ac7a6d5988ac9093510d000000001976a9143bde42dbee7e4dbe6a21b2d50ce2f0167faa815988ac000247304402203609e17b84f6a7d30c80bfa610b5b4542f32a8a0d5447a12fb1366d7f01cc44a0220573a954c4518331561406f90300e8f3358f51928d43c212a8caed02de67eebee0121025476c2e83188368da1ff3e292e7acafcdb3566bb0ad253f62fc70f07aeee635711000000"
126
127        rawTxSigned = self.nodes[0].signrawtransactionwithwallet(p2wpkh_raw_tx)
128
129        # 7) The transaction has no complete set of signatures
130        assert not rawTxSigned['complete']
131
132        # 8) Two script verification errors occurred
133        assert 'errors' in rawTxSigned
134        assert_equal(len(rawTxSigned['errors']), 2)
135
136        # 9) Script verification errors have certain properties
137        assert 'txid' in rawTxSigned['errors'][0]
138        assert 'vout' in rawTxSigned['errors'][0]
139        assert 'witness' in rawTxSigned['errors'][0]
140        assert 'scriptSig' in rawTxSigned['errors'][0]
141        assert 'sequence' in rawTxSigned['errors'][0]
142        assert 'error' in rawTxSigned['errors'][0]
143
144        # Non-empty witness checked here
145        assert_equal(rawTxSigned['errors'][1]['witness'], ["304402203609e17b84f6a7d30c80bfa610b5b4542f32a8a0d5447a12fb1366d7f01cc44a0220573a954c4518331561406f90300e8f3358f51928d43c212a8caed02de67eebee01", "025476c2e83188368da1ff3e292e7acafcdb3566bb0ad253f62fc70f07aeee6357"])
146        assert not rawTxSigned['errors'][0]['witness']
147
148    def test_fully_signed_tx(self):
149        self.log.info("Test signing a fully signed transaction does nothing")
150        self.nodes[0].walletpassphrase("password", 9999)
151        self.generate(self.nodes[0], COINBASE_MATURITY + 1)
152        rawtx = self.nodes[0].createrawtransaction([], [{self.nodes[0].getnewaddress(): 10}])
153        fundedtx = self.nodes[0].fundrawtransaction(rawtx)
154        signedtx = self.nodes[0].signrawtransactionwithwallet(fundedtx["hex"])
155        assert_equal(signedtx["complete"], True)
156        signedtx2 = self.nodes[0].signrawtransactionwithwallet(signedtx["hex"])
157        assert_equal(signedtx2["complete"], True)
158        assert_equal(signedtx["hex"], signedtx2["hex"])
159        self.nodes[0].walletlock()
160
161    def OP_1NEGATE_test(self):
162        self.log.info("Test OP_1NEGATE (0x4f) satisfies BIP62 minimal push standardness rule")
163        hex_str = (
164            "0200000001FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF"
165            "FFFFFFFF00000000044F024F9CFDFFFFFF01F0B9F5050000000023210277777777"
166            "77777777777777777777777777777777777777777777777777777777AC66030000"
167        )
168        prev_txs = [
169            {
170                "txid": "FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF",
171                "vout": 0,
172                "scriptPubKey": "A914AE44AB6E9AA0B71F1CD2B453B69340E9BFBAEF6087",
173                "redeemScript": "4F9C",
174                "amount": 1,
175            }
176        ]
177        txn = self.nodes[0].signrawtransactionwithwallet(hex_str, prev_txs)
178        assert txn["complete"]
179
180    def test_signing_with_csv(self):
181        self.log.info("Test signing a transaction containing a fully signed CSV input")
182        self.nodes[0].walletpassphrase("password", 9999)
183        getcontext().prec = 8
184
185        # Make sure CSV is active
186        assert self.nodes[0].getdeploymentinfo()['deployments']['csv']['active']
187
188        # Create a P2WSH script with CSV
189        script = CScript([1, OP_CHECKSEQUENCEVERIFY, OP_DROP])
190        address = script_to_p2wsh(script)
191
192        # Fund that address and make the spend
193        utxo1 = self.create_outpoints(self.nodes[0], outputs=[{address: 1}])[0]
194        self.generate(self.nodes[0], 1)
195        utxo2 = self.nodes[0].listunspent()[0]
196        amt = Decimal(1) + utxo2["amount"] - Decimal(0.00001)
197        tx = self.nodes[0].createrawtransaction(
198            [{**utxo1, "sequence": 1},{"txid": utxo2["txid"], "vout": utxo2["vout"]}],
199            [{self.nodes[0].getnewaddress(): amt}],
200            self.nodes[0].getblockcount()
201        )
202
203        # Set the witness script
204        ctx = tx_from_hex(tx)
205        ctx.wit.vtxinwit.append(CTxInWitness())
206        ctx.wit.vtxinwit[0].scriptWitness.stack = [CScript([OP_TRUE]), script]
207        tx = ctx.serialize_with_witness().hex()
208
209        # Sign and send the transaction
210        signed = self.nodes[0].signrawtransactionwithwallet(tx)
211        assert_equal(signed["complete"], True)
212        self.nodes[0].sendrawtransaction(signed["hex"])
213
214    def test_signing_with_cltv(self):
215        self.log.info("Test signing a transaction containing a fully signed CLTV input")
216        self.nodes[0].walletpassphrase("password", 9999)
217        getcontext().prec = 8
218
219        # Make sure CLTV is active
220        assert self.nodes[0].getdeploymentinfo()['deployments']['bip65']['active']
221
222        # Create a P2WSH script with CLTV
223        script = CScript([100, OP_CHECKLOCKTIMEVERIFY, OP_DROP])
224        address = script_to_p2wsh(script)
225
226        # Fund that address and make the spend
227        utxo1 = self.create_outpoints(self.nodes[0], outputs=[{address: 1}])[0]
228        self.generate(self.nodes[0], 1)
229        utxo2 = self.nodes[0].listunspent()[0]
230        amt = Decimal(1) + utxo2["amount"] - Decimal(0.00001)
231        tx = self.nodes[0].createrawtransaction(
232            [utxo1, {"txid": utxo2["txid"], "vout": utxo2["vout"]}],
233            [{self.nodes[0].getnewaddress(): amt}],
234            self.nodes[0].getblockcount()
235        )
236
237        # Set the witness script
238        ctx = tx_from_hex(tx)
239        ctx.wit.vtxinwit.append(CTxInWitness())
240        ctx.wit.vtxinwit[0].scriptWitness.stack = [CScript([OP_TRUE]), script]
241        tx = ctx.serialize_with_witness().hex()
242
243        # Sign and send the transaction
244        signed = self.nodes[0].signrawtransactionwithwallet(tx)
245        assert_equal(signed["complete"], True)
246        self.nodes[0].sendrawtransaction(signed["hex"])
247
248    def test_signing_with_missing_prevtx_info(self):
249        txid = "1d1d4e24ed99057e84c3f80fd8fbec79ed9e1acee37da269356ecea000000000"
250        for type in ["bech32", "p2sh-segwit", "legacy"]:

src/wallet/receive.cpp

src/wallet/coinselection.cpp

src/consensus/validation.h

src/primitives/transaction.cpp

src/script/descriptor.cpp

src/bitcoin-cli.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/init.cpp

src/crypto/sha256.cpp

src/consensus/merkle.h

src/consensus/tx_check.h

src/consensus/tx_verify.h

src/policy/feerate.h

src/policy/feerate.cpp

src/primitives/transaction_identifier.h

src/chainparamsbase.h

src/chainparamsbase.cpp

src/util/moneystr.cpp

src/crypto/ripemd160.h

src/crypto/sha1.h

src/crypto/sha512.h

src/crypto/hmac_sha256.h

src/crypto/hmac_sha512.h

src/crypto/hmac_sha256.cpp

src/crypto/hmac_sha512.cpp

src/crypto/hkdf_sha256_32.h

src/crypto/hkdf_sha256_32.cpp

src/support/cleanse.h

src/support/cleanse.cpp

src/crypto/siphash.cpp

src/crypto/muhash.h

src/crypto/chacha20.h

src/crypto/poly1305.h

src/crypto/chacha20poly1305.h

src/crypto/chacha20poly1305.cpp

src/util/chaintype.cpp

src/util/obfuscation.h

src/util/byte_units.h

src/util/overflow.h

src/blockencodings.cpp

src/net_permissions.cpp

src/policy/packages.cpp

src/policy/rbf.cpp

src/policy/truc_policy.cpp

src/policy/ephemeral_policy.cpp

src/policy/settings.cpp

src/policy/policy.cpp

src/node/transaction.cpp

src/node/coin.cpp

src/rpc/client.cpp

src/rpc/external_signer.cpp

src/rpc/request.cpp

src/rpc/server_util.cpp

src/rpc/fees.cpp

src/rpc/output_script.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/rawtransaction_util.h

src/rpc/register.h

src/rpc/request.h

src/rpc/server_util.h

src/rpc/protocol.h

src/rpc/server.h

src/rpc/signmessage.cpp

src/rpc/txoutproof.cpp

src/rpc/util.cpp

src/rpc/util.h

src/wallet/rpc/addresses.cpp

src/wallet/rpc/backup.cpp

src/wallet/rpc/coins.cpp

src/wallet/rpc/encrypt.cpp

src/wallet/rpc/signmessage.cpp

src/wallet/rpc/util.cpp

src/wallet/rpc/util.h

src/wallet/coincontrol.cpp

src/wallet/coincontrol.h

src/wallet/context.cpp

src/wallet/context.h

src/wallet/crypter.cpp

src/wallet/crypter.h

src/wallet/db.cpp

src/wallet/export.cpp

src/wallet/external_signer_scriptpubkeyman.cpp

src/wallet/rpc/spend.cpp

src/wallet/rpc/transactions.cpp

src/wallet/rpc/wallet.cpp

src/wallet/feebumper.cpp

src/wallet/feebumper.h

src/index/base.h

src/index/base.cpp

src/index/txindex.h

src/index/txindex.cpp

src/index/txindex_key.h

src/index/txospenderindex.h

src/index/txospenderindex.cpp

src/index/blockfilterindex.h

src/index/blockfilterindex.cpp

src/index/coinstatsindex.h

src/index/coinstatsindex.cpp

src/index/db_key.h

src/index/disktxpos.h

src/kernel/chain.cpp

src/kernel/chain.h

src/kernel/checks.cpp

src/kernel/checks.h

src/kernel/context.cpp

src/kernel/context.h

src/kernel/cs_main.cpp

src/kernel/cs_main.h

src/kernel/disconnected_transactions.cpp

src/kernel/disconnected_transactions.h

src/kernel/mempool_removal_reason.cpp

src/kernel/mempool_removal_reason.h

src/kernel/coinstats.cpp

src/kernel/coinstats.h

src/kernel/chainparams.cpp

src/kernel/chainparams.h

src/wallet/sqlite.cpp

src/wallet/sqlite.h

src/wallet/transaction.cpp

src/wallet/transaction.h

src/wallet/dump.cpp

src/wallet/dump.h

src/wallet/init.cpp

src/wallet/walletutil.cpp

src/wallet/walletutil.h

src/wallet/wallettool.cpp

src/wallet/wallettool.h

src/wallet/export.h

src/wallet/migrate.cpp

src/wallet/migrate.h

src/wallet/db.h

src/wallet/walletdb.cpp

src/wallet/interfaces.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/scriptpubkeyman.h

src/kernel/bitcoinkernel.cpp

src/kernel/bitcoinkernel.h

src/kernel/bitcoinkernel_wrapper.h

src/node/chainstate.cpp

src/node/chainstate.h

src/node/blockstorage.cpp

src/node/blockstorage.h

src/node/mempool_persist.cpp

src/node/mempool_persist.h

src/node/utxo_snapshot.cpp

src/node/utxo_snapshot.h

src/node/kernel_notifications.cpp

src/node/kernel_notifications.h

src/node/blockmanager_args.cpp

src/kernel/blockmanager_opts.h

src/util/expected.cpp

src/policy/settings.h

src/util/types.h

src/kernel/messagestartchars.h

src/kernel/warning.h

src/util/exception.h

src/common/license_info.h

src/node/coins_view_args.h

src/node/database_args.h

src/util/batchpriority.h

src/util/ui_change_type.h

src/node/coins_view_args.cpp

src/node/peerman_args.h

src/util/serfloat.h

src/node/blockmanager_args.h

src/node/database_args.cpp

src/util/overloaded.h

src/interfaces/types.h

src/node/chainstatemanager_args.h

src/node/minisketchwrapper.h

src/util/macros.h

src/util/syserror.h

src/common/run_command.h

src/util/bytevectorhash.cpp

src/node/mempool_persist_args.cpp

src/util/exec.h

src/util/rbf.h

src/crypto/hex_base.h

src/node/mempool_persist_args.h

src/interfaces/echo.h

src/util/any.h

src/util/batchpriority.cpp

src/util/threadnames.h

src/node/coin.h

src/node/mempool_args.h

src/util/asmap.h

src/util/bytevectorhash.h

src/node/context.cpp

src/util/insert.h

src/util/readwritefile.h

src/node/peerman_args.cpp

src/node/interface_ui.cpp

src/interfaces/handler.h

src/node/mining_args.h

src/util/hasher.cpp

src/common/init.h

src/kernel/mempool_limits.h

src/common/system.h

src/crypto/sha3.h

src/util/threadinterrupt.cpp

src/node/protocol_version.h

src/util/exception.cpp

src/common/messages.h

src/node/connection_types.cpp

src/util/bip32.h

src/common/license_info.cpp

src/util/stdmutex.h

src/common/run_command.cpp

src/util/check.cpp

src/util/golombrice.h

src/node/types.h

src/node/timeoffsets.h

src/util/readwritefile.cpp

src/util/fastrange.h

src/util/signalinterrupt.h

src/util/task_runner.h

src/util/syserror.cpp

src/common/interfaces.cpp

src/common/types.h

src/util/threadinterrupt.h

src/kernel/chainstatemanager_opts.h

src/node/psbt.h

src/policy/ephemeral_policy.h

src/util/trace.h

src/common/url.cpp

src/kernel/mempool_options.h

src/util/serfloat.cpp

src/kernel/notifications_interface.h

src/node/timeoffsets.cpp

src/node/warnings.cpp

src/util/hash_type.h

src/crypto/hex_base.cpp

src/node/eviction.h

src/util/tokenbucket.h

src/crypto/aes.h

src/common/pcp.h

src/util/feefrac.cpp

src/node/transaction.h

src/util/threadnames.cpp

src/common/signmessage.h

src/util/exec.cpp

src/util/signalinterrupt.cpp

src/clientversion.cpp

src/common/signmessage.cpp

src/compat/assumptions.h

src/compat/byteswap.h

src/deploymentinfo.cpp

src/deploymentinfo.h

src/deploymentstatus.cpp

src/deploymentstatus.h

src/dummywallet.cpp

src/external_signer.h

src/init/bitcoin-gui.cpp

src/init/bitcoin-node.cpp

src/init/bitcoin-qt.cpp

src/init/bitcoin-wallet.cpp

src/init/bitcoind.cpp

src/init/common.h

src/interfaces/init.h

src/interfaces/ipc.h

src/key_io.h

src/logging/categories.h

src/logging/timer.h

src/mapport.h

src/musig.h

src/net_permissions.h

src/netgroup.h

src/netmessagemaker.h

src/node/chainstatemanager_args.cpp

src/node/connection_types.h

src/node/context.h

src/node/interface_ui.h

src/node/mempool_args.cpp

src/node/mining_args.cpp

src/node/minisketchwrapper.cpp

src/node/txreconciliation.h

src/policy/fees/estimator_args.cpp

src/policy/fees/estimator_args.h

src/policy/fees/estimator_man.cpp

src/policy/fees/estimator_man.h

src/policy/packages.h

src/policy/rbf.h

src/policy/truc_policy.h

src/pow.h

src/primitives/block.cpp

src/randomenv.h

src/rest.h

src/script/keyorigin.h

src/script/parsing.cpp

src/script/parsing.h

src/script/script_error.h

src/script/sigcache.cpp

src/script/sigcache.h

src/script/solver.h

src/script/verify_flags.h

src/semaphore_grant.h

src/signet.h

src/span.h

src/support/allocators/secure.h

src/support/allocators/zeroafterfree.h

src/util/tokenpipe.cpp

src/util/translation.h

src/util/vector.h

src/versionbits.h

src/versionbits_impl.h

src/wallet/external_signer_scriptpubkeyman.h

src/wallet/fees.h

src/wallet/load.h

src/wallet/receive.h

src/wallet/rpc/wallet.h

src/wallet/types.h

src/walletinitinterface.h

src/zmq/zmqabstractnotifier.cpp

Independent explanations by MyBitcoinExplorer. Not affiliated with or endorsed by Bitcoin Core. Guides are educational and do not replace the source or its tests.

Bitcoin Core source © its contributors, distributed under the MIT license. Original notices and bundled third-party licenses are retained in the source tree.