READ THE CODE

Inside Bitcoin

The code behind the network, with room to understand it.

Stable release v32.1bitcoin/bitcoin · f0de87f04062 ↗3,020 source files · 47.5 MB stored on the server440 file guides

Release published 2026-10-28 · Snapshot fetched 2026-11-01. Latest stable release at fetch time; development branches and Git history are excluded. Only the selected code window and visible folders load here.

31,661 bytes · SHA-256 d8c0182ffdcbd172… · View upstream ↗

1#!/usr/bin/env python3
2# Copyright (c) 2024-present The Bitcoin Core developers
3# Distributed under the MIT software license, see the accompanying
4# file COPYING or http://www.opensource.org/licenses/mit-license.php.
5"""
6Test opportunistic 1p1c package submission logic.
7"""
8
9from decimal import Decimal
10import random
11import time
12
13from test_framework.blocktools import MAX_STANDARD_TX_WEIGHT
14from test_framework.mempool_util import (
15    create_large_orphan,
16    DEFAULT_MIN_RELAY_TX_FEE,
17    fill_mempool,
18)
19from test_framework.messages import (
20    CInv,
21    COIN,
22    COutPoint,
23    CTransaction,
24    CTxIn,
25    CTxOut,
26    CTxInWitness,
27    MAX_BIP125_RBF_SEQUENCE,
28    MSG_WTX,
29    msg_inv,
30    msg_tx,
31    tx_from_hex,
32)
33from test_framework.p2p import (
34    NONPREF_PEER_TX_DELAY,
35    P2PInterface,
36    TXID_RELAY_DELAY,
37)
38from test_framework.script import (
39    CScript,
40    OP_NOP,
41    OP_RETURN,
42)
43from test_framework.test_framework import BitcoinTestFramework
44from test_framework.util import (
45    assert_equal,
46    assert_greater_than,
47    assert_greater_than_or_equal,
48)
49from test_framework.wallet import (
50    MiniWallet,
51    MiniWalletMode,
52)
53
54# 1sat/vB feerate denominated in BTC/KvB
55FEERATE_1SAT_VB = Decimal("0.00001000")
56# Number of seconds to wait to ensure no getdata is received
57GETDATA_WAIT = 60
58
59def cleanup(func):
60    def wrapper(self, *args, **kwargs):
61        func(self, *args, **kwargs)
62
63        self.nodes[0].disconnect_p2ps()
64        # Do not clear the node's mempool, as each test requires mempool min feerate > min
65        # relay feerate. However, do check that this is the case.
66        assert_greater_than(self.nodes[0].getmempoolinfo()["mempoolminfee"], self.nodes[0].getnetworkinfo()["relayfee"])
67        # Ensure we do not try to spend the same UTXOs in subsequent tests, as they will look like RBF attempts.
68        self.wallet.rescan_utxos(include_mempool=True)
69
70        # Resets if mocktime was used
71        self.nodes[0].setmocktime(0)
72    return wrapper
73
74class PackageRelayTest(BitcoinTestFramework):
75    def set_test_params(self):
76        self.setup_clean_chain = True
77        self.num_nodes = 1
78        self.extra_args = [[
79            "-maxmempool=5","-inboundrelaypercent=100"
80        ]]
81
82    def create_tx_below_mempoolminfee(self, wallet, utxo_to_spend=None):
83        """Create a 1-input 0.1sat/vB transaction using a confirmed UTXO. Decrement and use
84        self.sequence so that subsequent calls to this function result in unique transactions."""
85
86        self.sequence -= 1
87        assert_greater_than(self.nodes[0].getmempoolinfo()["mempoolminfee"], Decimal(DEFAULT_MIN_RELAY_TX_FEE) / COIN)
88
89        return wallet.create_self_transfer(fee_rate=Decimal(DEFAULT_MIN_RELAY_TX_FEE) / COIN, sequence=self.sequence, utxo_to_spend=utxo_to_spend, confirmed_only=True)
90
91    @cleanup
92    def test_basic_child_then_parent(self):
93        node = self.nodes[0]
94        self.log.info("Check that opportunistic 1p1c logic works when child is received before parent")
95        node.setmocktime(int(time.time()))
96
97        low_fee_parent = self.create_tx_below_mempoolminfee(self.wallet)
98        high_fee_child = self.wallet.create_self_transfer(utxo_to_spend=low_fee_parent["new_utxo"], fee_rate=20*FEERATE_1SAT_VB)
99
100        peer_sender = node.add_p2p_connection(P2PInterface())
101
102        # 1. Child is received first (perhaps the low feerate parent didn't meet feefilter or the requests were sent to different nodes). It is missing an input.
103        high_child_wtxid_int = high_fee_child["tx"].wtxid_int
104        peer_sender.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=high_child_wtxid_int)]))
105        node.bumpmocktime(NONPREF_PEER_TX_DELAY)
106        peer_sender.wait_for_getdata([high_child_wtxid_int])
107        peer_sender.send_and_ping(msg_tx(high_fee_child["tx"]))
108
109        # 2. Node requests the missing parent by txid.
110        parent_txid_int = int(low_fee_parent["txid"], 16)
111        node.bumpmocktime(NONPREF_PEER_TX_DELAY + TXID_RELAY_DELAY)
112        peer_sender.wait_for_getdata([parent_txid_int])
113
114        # 3. Sender relays the parent. Parent+Child are evaluated as a package and accepted.
115        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
116
117        # 4. Both transactions should now be in mempool.
118        node_mempool = node.getrawmempool()
119        assert low_fee_parent["txid"] in node_mempool
120        assert high_fee_child["txid"] in node_mempool
121
122        node.disconnect_p2ps()
123
124    @cleanup
125    def test_basic_parent_then_child(self, wallet):
126        node = self.nodes[0]
127        node.setmocktime(int(time.time()))
128        low_fee_parent = self.create_tx_below_mempoolminfee(wallet)
129        high_fee_child = wallet.create_self_transfer(utxo_to_spend=low_fee_parent["new_utxo"], fee_rate=20*FEERATE_1SAT_VB)
130
131        peer_sender = node.add_outbound_p2p_connection(P2PInterface(), p2p_idx=1, connection_type="outbound-full-relay")
132        peer_ignored = node.add_outbound_p2p_connection(P2PInterface(), p2p_idx=2, connection_type="outbound-full-relay")
133
134        # 1. Parent is relayed first. It is too low feerate.
135        parent_wtxid_int = low_fee_parent["tx"].wtxid_int
136        peer_sender.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=parent_wtxid_int)]))
137        peer_sender.wait_for_getdata([parent_wtxid_int])
138        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
139        assert low_fee_parent["txid"] not in node.getrawmempool()
140
141        # Send again from peer_ignored, check that it is ignored
142        peer_ignored.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=parent_wtxid_int)]))
143        assert "getdata" not in peer_ignored.last_message
144
145        # 2. Child is relayed next. It is missing an input.
146        high_child_wtxid_int = high_fee_child["tx"].wtxid_int
147        peer_sender.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=high_child_wtxid_int)]))
148        peer_sender.wait_for_getdata([high_child_wtxid_int])
149        peer_sender.send_and_ping(msg_tx(high_fee_child["tx"]))
150
151        # 3. Node requests the missing parent by txid.
152        # It should do so even if it has previously rejected that parent for being too low feerate.
153        parent_txid_int = int(low_fee_parent["txid"], 16)
154        node.bumpmocktime(TXID_RELAY_DELAY)
155        peer_sender.wait_for_getdata([parent_txid_int])
156
157        # 4. Sender re-relays the parent. Parent+Child are evaluated as a package and accepted.
158        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
159
160        # 5. Both transactions should now be in mempool.
161        node_mempool = node.getrawmempool()
162        assert low_fee_parent["txid"] in node_mempool
163        assert high_fee_child["txid"] in node_mempool
164
165    @cleanup
166    def test_low_and_high_child(self, wallet):
167        node = self.nodes[0]
168        node.setmocktime(int(time.time()))
169        low_fee_parent = self.create_tx_below_mempoolminfee(wallet)
170        # This feerate is above mempoolminfee, but not enough to also bump the low feerate parent.
171        feerate_just_above = node.getmempoolinfo()["mempoolminfee"]
172        med_fee_child = wallet.create_self_transfer(utxo_to_spend=low_fee_parent["new_utxo"], fee_rate=feerate_just_above)
173        high_fee_child = wallet.create_self_transfer(utxo_to_spend=low_fee_parent["new_utxo"], fee_rate=999*FEERATE_1SAT_VB)
174
175        peer_sender = node.add_outbound_p2p_connection(P2PInterface(), p2p_idx=1, connection_type="outbound-full-relay")
176        peer_ignored = node.add_outbound_p2p_connection(P2PInterface(), p2p_idx=2, connection_type="outbound-full-relay")
177
178        self.log.info("Check that tx caches low fee parent + low fee child package rejections")
179
180        # 1. Send parent, rejected for being low feerate.
181        parent_wtxid_int = low_fee_parent["tx"].wtxid_int
182        peer_sender.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=parent_wtxid_int)]))
183        peer_sender.wait_for_getdata([parent_wtxid_int])
184        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
185        assert low_fee_parent["txid"] not in node.getrawmempool()
186
187        # Send again from peer_ignored, check that it is ignored
188        peer_ignored.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=parent_wtxid_int)]))
189        assert "getdata" not in peer_ignored.last_message
190
191        # 2. Send an (orphan) child that has a higher feerate, but not enough to bump the parent.
192        med_child_wtxid_int = med_fee_child["tx"].wtxid_int
193        peer_sender.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=med_child_wtxid_int)]))
194        peer_sender.wait_for_getdata([med_child_wtxid_int])
195        peer_sender.send_and_ping(msg_tx(med_fee_child["tx"]))
196
197        # 3. Node requests the orphan's missing parent.
198        parent_txid_int = int(low_fee_parent["txid"], 16)
199        node.bumpmocktime(TXID_RELAY_DELAY)
200        peer_sender.wait_for_getdata([parent_txid_int])
201
202        # 4. The low parent + low child are submitted as a package. They are not accepted due to low package feerate.
203        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
204
205        assert low_fee_parent["txid"] not in node.getrawmempool()
206        assert med_fee_child["txid"] not in node.getrawmempool()
207
208        # If peer_ignored announces the low feerate child, it should be ignored
209        peer_ignored.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=med_child_wtxid_int)]))
210        assert "getdata" not in peer_ignored.last_message
211        # If either peer sends the parent again, package evaluation should not be attempted
212        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
213        peer_ignored.send_and_ping(msg_tx(low_fee_parent["tx"]))
214
215        assert low_fee_parent["txid"] not in node.getrawmempool()
216        assert med_fee_child["txid"] not in node.getrawmempool()
217
218        # 5. Send the high feerate (orphan) child
219        high_child_wtxid_int = high_fee_child["tx"].wtxid_int
220        peer_sender.send_and_ping(msg_inv([CInv(t=MSG_WTX, h=high_child_wtxid_int)]))
221        peer_sender.wait_for_getdata([high_child_wtxid_int])
222        peer_sender.send_and_ping(msg_tx(high_fee_child["tx"]))
223
224        # 6. Node requests the orphan's parent, even though it has already been rejected, both by
225        # itself and with a child. This is necessary, otherwise high_fee_child can be censored.
226        parent_txid_int = int(low_fee_parent["txid"], 16)
227        node.bumpmocktime(TXID_RELAY_DELAY)
228        peer_sender.wait_for_getdata([parent_txid_int])
229
230        # 7. The low feerate parent + high feerate child are submitted as a package.
231        peer_sender.send_and_ping(msg_tx(low_fee_parent["tx"]))
232
233        # 8. Both transactions should now be in mempool
234        node_mempool = node.getrawmempool()
235        assert low_fee_parent["txid"] in node_mempool
236        assert high_fee_child["txid"] in node_mempool
237        assert med_fee_child["txid"] not in node_mempool
238
239    @cleanup
240    def test_orphan_consensus_failure(self):
241        self.log.info("Check opportunistic 1p1c logic requires parent and child to be from the same peer")
242        node = self.nodes[0]
243        node.setmocktime(int(time.time()))
244        low_fee_parent = self.create_tx_below_mempoolminfee(self.wallet)
245        coin = low_fee_parent["new_utxo"]
246        address = node.get_deterministic_priv_key().address
247        # Create raw transaction spending the parent, but with no signature (a consensus error).
248        hex_orphan_no_sig = node.createrawtransaction([{"txid": coin["txid"], "vout": coin["vout"]}], {address : coin["value"] - Decimal("0.0001")})
249        tx_orphan_bad_wit = tx_from_hex(hex_orphan_no_sig)
250        tx_orphan_bad_wit.wit.vtxinwit.append(CTxInWitness())

src/wallet/receive.cpp

src/wallet/coinselection.cpp

src/consensus/validation.h

src/primitives/transaction.cpp

src/script/descriptor.cpp

src/bitcoin-cli.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/init.cpp

src/crypto/sha256.cpp

src/consensus/merkle.h

src/consensus/tx_check.h

src/consensus/tx_verify.h

src/policy/feerate.h

src/policy/feerate.cpp

src/primitives/transaction_identifier.h

src/chainparamsbase.h

src/chainparamsbase.cpp

src/util/moneystr.cpp

src/crypto/ripemd160.h

src/crypto/sha1.h

src/crypto/sha512.h

src/crypto/hmac_sha256.h

src/crypto/hmac_sha512.h

src/crypto/hmac_sha256.cpp

src/crypto/hmac_sha512.cpp

src/crypto/hkdf_sha256_32.h

src/crypto/hkdf_sha256_32.cpp

src/support/cleanse.h

src/support/cleanse.cpp

src/crypto/siphash.cpp

src/crypto/muhash.h

src/crypto/chacha20.h

src/crypto/poly1305.h

src/crypto/chacha20poly1305.h

src/crypto/chacha20poly1305.cpp

src/util/chaintype.cpp

src/util/obfuscation.h

src/util/byte_units.h

src/util/overflow.h

src/blockencodings.cpp

src/net_permissions.cpp

src/policy/packages.cpp

src/policy/rbf.cpp

src/policy/truc_policy.cpp

src/policy/ephemeral_policy.cpp

src/policy/settings.cpp

src/policy/policy.cpp

src/node/transaction.cpp

src/node/coin.cpp

src/rpc/client.cpp

src/rpc/external_signer.cpp

src/rpc/request.cpp

src/rpc/server_util.cpp

src/rpc/fees.cpp

src/rpc/output_script.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/rawtransaction_util.h

src/rpc/register.h

src/rpc/request.h

src/rpc/server_util.h

src/rpc/protocol.h

src/rpc/server.h

src/rpc/signmessage.cpp

src/rpc/txoutproof.cpp

src/rpc/util.cpp

src/rpc/util.h

src/wallet/rpc/addresses.cpp

src/wallet/rpc/backup.cpp

src/wallet/rpc/coins.cpp

src/wallet/rpc/encrypt.cpp

src/wallet/rpc/signmessage.cpp

src/wallet/rpc/util.cpp

src/wallet/rpc/util.h

src/wallet/coincontrol.cpp

src/wallet/coincontrol.h

src/wallet/context.cpp

src/wallet/context.h

src/wallet/crypter.cpp

src/wallet/crypter.h

src/wallet/db.cpp

src/wallet/export.cpp

src/wallet/external_signer_scriptpubkeyman.cpp

src/wallet/rpc/spend.cpp

src/wallet/rpc/transactions.cpp

src/wallet/rpc/wallet.cpp

src/wallet/feebumper.cpp

src/wallet/feebumper.h

src/index/base.h

src/index/base.cpp

src/index/txindex.h

src/index/txindex.cpp

src/index/txindex_key.h

src/index/txospenderindex.h

src/index/txospenderindex.cpp

src/index/blockfilterindex.h

src/index/blockfilterindex.cpp

src/index/coinstatsindex.h

src/index/coinstatsindex.cpp

src/index/db_key.h

src/index/disktxpos.h

src/kernel/chain.cpp

src/kernel/chain.h

src/kernel/checks.cpp

src/kernel/checks.h

src/kernel/context.cpp

src/kernel/context.h

src/kernel/cs_main.cpp

src/kernel/cs_main.h

src/kernel/disconnected_transactions.cpp

src/kernel/disconnected_transactions.h

src/kernel/mempool_removal_reason.cpp

src/kernel/mempool_removal_reason.h

src/kernel/coinstats.cpp

src/kernel/coinstats.h

src/kernel/chainparams.cpp

src/kernel/chainparams.h

src/wallet/sqlite.cpp

src/wallet/sqlite.h

src/wallet/transaction.cpp

src/wallet/transaction.h

src/wallet/dump.cpp

src/wallet/dump.h

src/wallet/init.cpp

src/wallet/walletutil.cpp

src/wallet/walletutil.h

src/wallet/wallettool.cpp

src/wallet/wallettool.h

src/wallet/export.h

src/wallet/migrate.cpp

src/wallet/migrate.h

src/wallet/db.h

src/wallet/walletdb.cpp

src/wallet/interfaces.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/scriptpubkeyman.h

src/kernel/bitcoinkernel.cpp

src/kernel/bitcoinkernel.h

src/kernel/bitcoinkernel_wrapper.h

src/node/chainstate.cpp

src/node/chainstate.h

src/node/blockstorage.cpp

src/node/blockstorage.h

src/node/mempool_persist.cpp

src/node/mempool_persist.h

src/node/utxo_snapshot.cpp

src/node/utxo_snapshot.h

src/node/kernel_notifications.cpp

src/node/kernel_notifications.h

src/node/blockmanager_args.cpp

src/kernel/blockmanager_opts.h

src/util/expected.cpp

src/policy/settings.h

src/util/types.h

src/kernel/messagestartchars.h

src/kernel/warning.h

src/util/exception.h

src/common/license_info.h

src/node/coins_view_args.h

src/node/database_args.h

src/util/batchpriority.h

src/util/ui_change_type.h

src/node/coins_view_args.cpp

src/node/peerman_args.h

src/util/serfloat.h

src/node/blockmanager_args.h

src/node/database_args.cpp

src/util/overloaded.h

src/interfaces/types.h

src/node/chainstatemanager_args.h

src/node/minisketchwrapper.h

src/util/macros.h

src/util/syserror.h

src/common/run_command.h

src/util/bytevectorhash.cpp

src/node/mempool_persist_args.cpp

src/util/exec.h

src/util/rbf.h

src/crypto/hex_base.h

src/node/mempool_persist_args.h

src/interfaces/echo.h

src/util/any.h

src/util/batchpriority.cpp

src/util/threadnames.h

src/node/coin.h

src/node/mempool_args.h

src/util/asmap.h

src/util/bytevectorhash.h

src/node/context.cpp

src/util/insert.h

src/util/readwritefile.h

src/node/peerman_args.cpp

src/node/interface_ui.cpp

src/interfaces/handler.h

src/node/mining_args.h

src/util/hasher.cpp

src/common/init.h

src/kernel/mempool_limits.h

src/common/system.h

src/crypto/sha3.h

src/util/threadinterrupt.cpp

src/node/protocol_version.h

src/util/exception.cpp

src/common/messages.h

src/node/connection_types.cpp

src/util/bip32.h

src/common/license_info.cpp

src/util/stdmutex.h

src/common/run_command.cpp

src/util/check.cpp

src/util/golombrice.h

src/node/types.h

src/node/timeoffsets.h

src/util/readwritefile.cpp

src/util/fastrange.h

src/util/signalinterrupt.h

src/util/task_runner.h

src/util/syserror.cpp

src/common/interfaces.cpp

src/common/types.h

src/util/threadinterrupt.h

src/kernel/chainstatemanager_opts.h

src/node/psbt.h

src/policy/ephemeral_policy.h

src/util/trace.h

src/common/url.cpp

src/kernel/mempool_options.h

src/util/serfloat.cpp

src/kernel/notifications_interface.h

src/node/timeoffsets.cpp

src/node/warnings.cpp

src/util/hash_type.h

src/crypto/hex_base.cpp

src/node/eviction.h

src/util/tokenbucket.h

src/crypto/aes.h

src/common/pcp.h

src/util/feefrac.cpp

src/node/transaction.h

src/util/threadnames.cpp

src/common/signmessage.h

src/util/exec.cpp

src/util/signalinterrupt.cpp

src/clientversion.cpp

src/common/signmessage.cpp

src/compat/assumptions.h

src/compat/byteswap.h

src/deploymentinfo.cpp

src/deploymentinfo.h

src/deploymentstatus.cpp

src/deploymentstatus.h

src/dummywallet.cpp

src/external_signer.h

src/init/bitcoin-gui.cpp

src/init/bitcoin-node.cpp

src/init/bitcoin-qt.cpp

src/init/bitcoin-wallet.cpp

src/init/bitcoind.cpp

src/init/common.h

src/interfaces/init.h

src/interfaces/ipc.h

src/key_io.h

src/logging/categories.h

src/logging/timer.h

src/mapport.h

src/musig.h

src/net_permissions.h

src/netgroup.h

src/netmessagemaker.h

src/node/chainstatemanager_args.cpp

src/node/connection_types.h

src/node/context.h

src/node/interface_ui.h

src/node/mempool_args.cpp

src/node/mining_args.cpp

src/node/minisketchwrapper.cpp

src/node/txreconciliation.h

src/policy/fees/estimator_args.cpp

src/policy/fees/estimator_args.h

src/policy/fees/estimator_man.cpp

src/policy/fees/estimator_man.h

src/policy/packages.h

src/policy/rbf.h

src/policy/truc_policy.h

src/pow.h

src/primitives/block.cpp

src/randomenv.h

src/rest.h

src/script/keyorigin.h

src/script/parsing.cpp

src/script/parsing.h

src/script/script_error.h

src/script/sigcache.cpp

src/script/sigcache.h

src/script/solver.h

src/script/verify_flags.h

src/semaphore_grant.h

src/signet.h

src/span.h

src/support/allocators/secure.h

src/support/allocators/zeroafterfree.h

src/util/tokenpipe.cpp

src/util/translation.h

src/util/vector.h

src/versionbits.h

src/versionbits_impl.h

src/wallet/external_signer_scriptpubkeyman.h

src/wallet/fees.h

src/wallet/load.h

src/wallet/receive.h

src/wallet/rpc/wallet.h

src/wallet/types.h

src/walletinitinterface.h

src/zmq/zmqabstractnotifier.cpp

Independent explanations by MyBitcoinExplorer. Not affiliated with or endorsed by Bitcoin Core. Guides are educational and do not replace the source or its tests.

Bitcoin Core source © its contributors, distributed under the MIT license. Original notices and bundled third-party licenses are retained in the source tree.