READ THE CODE

Inside Bitcoin

The code behind the network, with room to understand it.

Stable release v32.1bitcoin/bitcoin · f0de87f04062 ↗3,020 source files · 47.5 MB stored on the server440 file guides

Release published 2026-10-28 · Snapshot fetched 2026-11-01. Latest stable release at fetch time; development branches and Git history are excluded. Only the selected code window and visible folders load here.

84,730 bytes · SHA-256 f5f2441a4591f9b9… · View upstream ↗

1#!/usr/bin/env python3
2# Copyright (c) 2014-present The Bitcoin Core developers
3# Distributed under the MIT software license, see the accompanying
4# file COPYING or http://www.opensource.org/licenses/mit-license.php.
5"""Test the fundrawtransaction RPC."""
6
7
8from decimal import Decimal
9from itertools import product
10from math import ceil
11from test_framework.address import address_to_scriptpubkey
12
13from test_framework.descriptors import descsum_create
14from test_framework.extendedkey import ExtendedPrivateKey
15from test_framework.messages import (
16    COIN,
17    CTransaction,
18    CTxOut,
19)
20from test_framework.test_framework import BitcoinTestFramework
21from test_framework.util import (
22    assert_not_equal,
23    assert_approx,
24    assert_equal,
25    assert_fee_amount,
26    assert_greater_than,
27    assert_greater_than_or_equal,
28    assert_raises_rpc_error,
29    count_bytes,
30    get_fee,
31)
32from test_framework.wallet_util import generate_keypair, WalletUnlock
33
34ERR_NOT_ENOUGH_PRESET_INPUTS = "The preselected coins total amount does not cover the transaction target. " \
35                               "Please allow other inputs to be automatically selected or include more coins manually"
36
37def get_unspent(listunspent, amount):
38    for utx in listunspent:
39        if utx['amount'] == amount:
40            return utx
41    raise AssertionError('Could not find unspent with amount={}'.format(amount))
42
43class RawTransactionsTest(BitcoinTestFramework):
44    def set_test_params(self):
45        self.num_nodes = 4
46        self.extra_args = [[
47            "-minrelaytxfee=0.00001000",
48        ] for i in range(self.num_nodes)]
49
50        self.setup_clean_chain = True
51        # whitelist peers to speed up tx relay / mempool sync
52        self.noban_tx_relay = True
53        self.rpc_timeout = 90  # to prevent timeouts in `test_transaction_too_large`
54        self.supports_cli = False
55
56    def skip_test_if_missing_module(self):
57        self.skip_if_no_wallet()
58
59    def setup_network(self):
60        self.setup_nodes()
61
62        self.connect_nodes(0, 1)
63        self.connect_nodes(1, 2)
64        self.connect_nodes(0, 2)
65        self.connect_nodes(0, 3)
66
67    def lock_outputs_type(self, wallet, outputtype):
68        """
69        Only allow UTXOs of the given type
70        """
71        if outputtype in ["legacy", "p2pkh", "pkh"]:
72            prefixes = ["pkh(", "sh(multi("]
73        elif outputtype in ["p2sh-segwit", "sh_wpkh"]:
74            prefixes = ["sh(wpkh(", "sh(wsh("]
75        elif outputtype in ["bech32", "wpkh"]:
76            prefixes = ["wpkh(", "wsh("]
77        else:
78            assert False, f"Unknown output type {outputtype}"
79
80        to_lock = []
81        for utxo in wallet.listunspent():
82            if "desc" in utxo:
83                for prefix in prefixes:
84                    if utxo["desc"].startswith(prefix):
85                        to_lock.append({"txid": utxo["txid"], "vout": utxo["vout"]})
86        wallet.lockunspent(False, to_lock)
87
88    def unlock_utxos(self, wallet):
89        """
90        Unlock all UTXOs except the watchonly one
91        """
92        to_keep = []
93        if self.watchonly_utxo is not None:
94            to_keep.append(self.watchonly_utxo)
95        wallet.lockunspent(True)
96        wallet.lockunspent(False, to_keep)
97
98    def run_test(self):
99        self.watchonly_utxo = None
100        self.log.info("Connect nodes, set fees, generate blocks, and sync")
101        self.min_relay_tx_fee = self.nodes[0].getnetworkinfo()['relayfee']
102        # This test is not meant to test fee estimation and we'd like
103        # to be sure all txs are sent at a consistent desired feerate
104        self.fee_rate_sats_per_vb = self.min_relay_tx_fee * Decimal(1e8) / 1000
105
106        # if the fee's positive delta is higher than this value tests will fail,
107        # neg. delta always fail the tests.
108        # The size of the signature of every input may be at most 2 bytes larger
109        # than a minimum sized signature.
110
111        #            = 2 bytes * minRelayTxFeePerByte
112        self.fee_tolerance = 2 * self.min_relay_tx_fee / 1000
113
114        self.generate(self.nodes[2], 1)
115        self.generate(self.nodes[0], 121)
116
117        self.test_add_inputs_default_value()
118        self.test_preset_inputs_selection()
119        self.test_weight_calculation()
120        self.test_weight_limits()
121        self.test_change_position()
122        self.test_simple()
123        self.test_simple_two_coins()
124        self.test_simple_two_outputs()
125        self.test_change()
126        self.test_no_change()
127        self.test_invalid_option()
128        self.test_invalid_change_address()
129        self.test_valid_change_address()
130        self.test_change_type()
131        self.test_coin_selection()
132        self.test_two_vin()
133        self.test_two_vin_two_vout()
134        self.test_invalid_input()
135        self.test_fee_p2pkh()
136        self.test_fee_p2pkh_multi_out()
137        self.test_fee_p2sh()
138        self.test_fee_4of5()
139        self.test_spend_2of2()
140        self.test_locked_wallet()
141        self.test_many_inputs_fee()
142        self.test_many_inputs_send()
143        self.test_op_return()
144        self.test_watchonly()
145        self.test_all_watched_funds()
146        self.test_option_feerate()
147        self.test_address_reuse()
148        self.test_option_subtract_fee_from_outputs()
149        self.test_subtract_fee_with_presets()
150        self.test_transaction_too_large()
151        self.test_include_unsafe()
152        self.test_external_inputs()
153        self.test_22670()
154        self.test_feerate_rounding()
155        self.test_input_confs_control()
156        self.test_duplicate_outputs()
157        self.test_watchonly_cannot_grind_r()
158        self.test_cannot_cover_fees()
159
160    def test_duplicate_outputs(self):
161        self.log.info("Test deserializing and funding a transaction with duplicate outputs")
162        self.nodes[1].createwallet("fundtx_duplicate_outputs")
163        w = self.nodes[1].get_wallet_rpc("fundtx_duplicate_outputs")
164
165        addr = w.getnewaddress(address_type="bech32")
166        self.nodes[0].sendtoaddress(addr, 5, fee_rate=self.fee_rate_sats_per_vb)
167        self.generate(self.nodes[0], 1)
168
169        address = self.nodes[0].getnewaddress("bech32")
170        tx = CTransaction()
171        tx.vin = []
172        tx.vout = [CTxOut(1 * COIN, bytearray(address_to_scriptpubkey(address)))] * 2
173        tx.nLockTime = 0
174        tx_hex = tx.serialize().hex()
175        res = w.fundrawtransaction(tx_hex, add_inputs=True, fee_rate=self.fee_rate_sats_per_vb)
176        signed_res = w.signrawtransactionwithwallet(res["hex"])
177        txid = w.sendrawtransaction(signed_res["hex"])
178        assert self.nodes[1].getrawtransaction(txid)
179
180        self.log.info("Test SFFO with duplicate outputs")
181
182        res_sffo = w.fundrawtransaction(tx_hex, add_inputs=True, subtractFeeFromOutputs=[0,1], fee_rate=self.fee_rate_sats_per_vb)
183        signed_res_sffo = w.signrawtransactionwithwallet(res_sffo["hex"])
184        txid_sffo = w.sendrawtransaction(signed_res_sffo["hex"])
185        assert self.nodes[1].getrawtransaction(txid_sffo)
186
187    def test_change_position(self):
188        """Ensure setting changePosition in fundraw with an exact match is handled properly."""
189        self.log.info("Test fundrawtxn changePosition option")
190        rawmatch = self.nodes[2].createrawtransaction([], {self.nodes[2].getnewaddress():50})
191        rawmatch = self.nodes[2].fundrawtransaction(rawmatch, changePosition=1, subtractFeeFromOutputs=[0], fee_rate=self.fee_rate_sats_per_vb)
192        assert_equal(rawmatch["changepos"], -1)
193
194        self.nodes[3].createwallet(wallet_name="wwatch", disable_private_keys=True)
195        wwatch = self.nodes[3].get_wallet_rpc('wwatch')
196        watchonly_address = self.nodes[0].getnewaddress()
197        self.watchonly_amount = Decimal(200)
198        import_res = wwatch.importdescriptors([{"desc": self.nodes[0].getaddressinfo(watchonly_address)["desc"], "timestamp": "now"}])
199        assert_equal(import_res[0]["success"], True)
200        self.watchonly_utxo = self.create_outpoints(self.nodes[0], outputs=[{watchonly_address: self.watchonly_amount}])[0]
201
202        # Lock UTXO so nodes[0] doesn't accidentally spend it
203        self.nodes[0].lockunspent(False, [self.watchonly_utxo])
204
205        self.nodes[0].sendtoaddress(self.nodes[3].get_wallet_rpc(self.default_wallet_name).getnewaddress(), self.watchonly_amount / 10, fee_rate=self.fee_rate_sats_per_vb)
206
207        self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 1.5, fee_rate=self.fee_rate_sats_per_vb)
208        self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 1.0, fee_rate=self.fee_rate_sats_per_vb)
209        self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 5.0, fee_rate=self.fee_rate_sats_per_vb)
210
211        self.generate(self.nodes[0], 1)
212
213        wwatch.unloadwallet()
214
215    def test_simple(self):
216        self.log.info("Test fundrawtxn")
217        inputs  = [ ]
218        outputs = { self.nodes[0].getnewaddress() : 1.0 }
219        rawtx   = self.nodes[2].createrawtransaction(inputs, outputs)
220        rawtxfund = self.nodes[2].fundrawtransaction(rawtx, fee_rate=self.fee_rate_sats_per_vb)
221        dec_tx  = self.nodes[2].decoderawtransaction(rawtxfund['hex'])
222        assert len(dec_tx['vin']) > 0  #test that we have enough inputs
223
224    def test_simple_two_coins(self):
225        self.log.info("Test fundrawtxn with 2 coins")
226        inputs  = [ ]
227        outputs = { self.nodes[0].getnewaddress() : 2.2 }
228        rawtx   = self.nodes[2].createrawtransaction(inputs, outputs)
229        rawtxfund = self.nodes[2].fundrawtransaction(rawtx, fee_rate=self.fee_rate_sats_per_vb)
230        dec_tx  = self.nodes[2].decoderawtransaction(rawtxfund['hex'])
231        assert len(dec_tx['vin']) > 0  #test if we have enough inputs
232        assert_equal(dec_tx['vin'][0]['scriptSig']['hex'], '')
233
234    def test_simple_two_outputs(self):
235        self.log.info("Test fundrawtxn with 2 outputs")
236
237        inputs  = [ ]
238        outputs = { self.nodes[0].getnewaddress() : 2.6, self.nodes[1].getnewaddress() : 2.5 }
239        rawtx   = self.nodes[2].createrawtransaction(inputs, outputs)
240
241        rawtxfund = self.nodes[2].fundrawtransaction(rawtx, fee_rate=self.fee_rate_sats_per_vb)
242        dec_tx  = self.nodes[2].decoderawtransaction(rawtxfund['hex'])
243
244        assert len(dec_tx['vin']) > 0
245        assert_equal(dec_tx['vin'][0]['scriptSig']['hex'], '')
246
247    def test_change(self):
248        self.log.info("Test fundrawtxn with a vin > required amount")
249        utx = get_unspent(self.nodes[2].listunspent(), 5)
250

src/wallet/receive.cpp

src/wallet/coinselection.cpp

src/consensus/validation.h

src/primitives/transaction.cpp

src/script/descriptor.cpp

src/bitcoin-cli.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/init.cpp

src/crypto/sha256.cpp

src/consensus/merkle.h

src/consensus/tx_check.h

src/consensus/tx_verify.h

src/policy/feerate.h

src/policy/feerate.cpp

src/primitives/transaction_identifier.h

src/chainparamsbase.h

src/chainparamsbase.cpp

src/util/moneystr.cpp

src/crypto/ripemd160.h

src/crypto/sha1.h

src/crypto/sha512.h

src/crypto/hmac_sha256.h

src/crypto/hmac_sha512.h

src/crypto/hmac_sha256.cpp

src/crypto/hmac_sha512.cpp

src/crypto/hkdf_sha256_32.h

src/crypto/hkdf_sha256_32.cpp

src/support/cleanse.h

src/support/cleanse.cpp

src/crypto/siphash.cpp

src/crypto/muhash.h

src/crypto/chacha20.h

src/crypto/poly1305.h

src/crypto/chacha20poly1305.h

src/crypto/chacha20poly1305.cpp

src/util/chaintype.cpp

src/util/obfuscation.h

src/util/byte_units.h

src/util/overflow.h

src/blockencodings.cpp

src/net_permissions.cpp

src/policy/packages.cpp

src/policy/rbf.cpp

src/policy/truc_policy.cpp

src/policy/ephemeral_policy.cpp

src/policy/settings.cpp

src/policy/policy.cpp

src/node/transaction.cpp

src/node/coin.cpp

src/rpc/client.cpp

src/rpc/external_signer.cpp

src/rpc/request.cpp

src/rpc/server_util.cpp

src/rpc/fees.cpp

src/rpc/output_script.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/rawtransaction_util.h

src/rpc/register.h

src/rpc/request.h

src/rpc/server_util.h

src/rpc/protocol.h

src/rpc/server.h

src/rpc/signmessage.cpp

src/rpc/txoutproof.cpp

src/rpc/util.cpp

src/rpc/util.h

src/wallet/rpc/addresses.cpp

src/wallet/rpc/backup.cpp

src/wallet/rpc/coins.cpp

src/wallet/rpc/encrypt.cpp

src/wallet/rpc/signmessage.cpp

src/wallet/rpc/util.cpp

src/wallet/rpc/util.h

src/wallet/coincontrol.cpp

src/wallet/coincontrol.h

src/wallet/context.cpp

src/wallet/context.h

src/wallet/crypter.cpp

src/wallet/crypter.h

src/wallet/db.cpp

src/wallet/export.cpp

src/wallet/external_signer_scriptpubkeyman.cpp

src/wallet/rpc/spend.cpp

src/wallet/rpc/transactions.cpp

src/wallet/rpc/wallet.cpp

src/wallet/feebumper.cpp

src/wallet/feebumper.h

src/index/base.h

src/index/base.cpp

src/index/txindex.h

src/index/txindex.cpp

src/index/txindex_key.h

src/index/txospenderindex.h

src/index/txospenderindex.cpp

src/index/blockfilterindex.h

src/index/blockfilterindex.cpp

src/index/coinstatsindex.h

src/index/coinstatsindex.cpp

src/index/db_key.h

src/index/disktxpos.h

src/kernel/chain.cpp

src/kernel/chain.h

src/kernel/checks.cpp

src/kernel/checks.h

src/kernel/context.cpp

src/kernel/context.h

src/kernel/cs_main.cpp

src/kernel/cs_main.h

src/kernel/disconnected_transactions.cpp

src/kernel/disconnected_transactions.h

src/kernel/mempool_removal_reason.cpp

src/kernel/mempool_removal_reason.h

src/kernel/coinstats.cpp

src/kernel/coinstats.h

src/kernel/chainparams.cpp

src/kernel/chainparams.h

src/wallet/sqlite.cpp

src/wallet/sqlite.h

src/wallet/transaction.cpp

src/wallet/transaction.h

src/wallet/dump.cpp

src/wallet/dump.h

src/wallet/init.cpp

src/wallet/walletutil.cpp

src/wallet/walletutil.h

src/wallet/wallettool.cpp

src/wallet/wallettool.h

src/wallet/export.h

src/wallet/migrate.cpp

src/wallet/migrate.h

src/wallet/db.h

src/wallet/walletdb.cpp

src/wallet/interfaces.cpp

src/wallet/scriptpubkeyman.cpp

src/wallet/scriptpubkeyman.h

src/kernel/bitcoinkernel.cpp

src/kernel/bitcoinkernel.h

src/kernel/bitcoinkernel_wrapper.h

src/node/chainstate.cpp

src/node/chainstate.h

src/node/blockstorage.cpp

src/node/blockstorage.h

src/node/mempool_persist.cpp

src/node/mempool_persist.h

src/node/utxo_snapshot.cpp

src/node/utxo_snapshot.h

src/node/kernel_notifications.cpp

src/node/kernel_notifications.h

src/node/blockmanager_args.cpp

src/kernel/blockmanager_opts.h

src/util/expected.cpp

src/policy/settings.h

src/util/types.h

src/kernel/messagestartchars.h

src/kernel/warning.h

src/util/exception.h

src/common/license_info.h

src/node/coins_view_args.h

src/node/database_args.h

src/util/batchpriority.h

src/util/ui_change_type.h

src/node/coins_view_args.cpp

src/node/peerman_args.h

src/util/serfloat.h

src/node/blockmanager_args.h

src/node/database_args.cpp

src/util/overloaded.h

src/interfaces/types.h

src/node/chainstatemanager_args.h

src/node/minisketchwrapper.h

src/util/macros.h

src/util/syserror.h

src/common/run_command.h

src/util/bytevectorhash.cpp

src/node/mempool_persist_args.cpp

src/util/exec.h

src/util/rbf.h

src/crypto/hex_base.h

src/node/mempool_persist_args.h

src/interfaces/echo.h

src/util/any.h

src/util/batchpriority.cpp

src/util/threadnames.h

src/node/coin.h

src/node/mempool_args.h

src/util/asmap.h

src/util/bytevectorhash.h

src/node/context.cpp

src/util/insert.h

src/util/readwritefile.h

src/node/peerman_args.cpp

src/node/interface_ui.cpp

src/interfaces/handler.h

src/node/mining_args.h

src/util/hasher.cpp

src/common/init.h

src/kernel/mempool_limits.h

src/common/system.h

src/crypto/sha3.h

src/util/threadinterrupt.cpp

src/node/protocol_version.h

src/util/exception.cpp

src/common/messages.h

src/node/connection_types.cpp

src/util/bip32.h

src/common/license_info.cpp

src/util/stdmutex.h

src/common/run_command.cpp

src/util/check.cpp

src/util/golombrice.h

src/node/types.h

src/node/timeoffsets.h

src/util/readwritefile.cpp

src/util/fastrange.h

src/util/signalinterrupt.h

src/util/task_runner.h

src/util/syserror.cpp

src/common/interfaces.cpp

src/common/types.h

src/util/threadinterrupt.h

src/kernel/chainstatemanager_opts.h

src/node/psbt.h

src/policy/ephemeral_policy.h

src/util/trace.h

src/common/url.cpp

src/kernel/mempool_options.h

src/util/serfloat.cpp

src/kernel/notifications_interface.h

src/node/timeoffsets.cpp

src/node/warnings.cpp

src/util/hash_type.h

src/crypto/hex_base.cpp

src/node/eviction.h

src/util/tokenbucket.h

src/crypto/aes.h

src/common/pcp.h

src/util/feefrac.cpp

src/node/transaction.h

src/util/threadnames.cpp

src/common/signmessage.h

src/util/exec.cpp

src/util/signalinterrupt.cpp

src/clientversion.cpp

src/common/signmessage.cpp

src/compat/assumptions.h

src/compat/byteswap.h

src/deploymentinfo.cpp

src/deploymentinfo.h

src/deploymentstatus.cpp

src/deploymentstatus.h

src/dummywallet.cpp

src/external_signer.h

src/init/bitcoin-gui.cpp

src/init/bitcoin-node.cpp

src/init/bitcoin-qt.cpp

src/init/bitcoin-wallet.cpp

src/init/bitcoind.cpp

src/init/common.h

src/interfaces/init.h

src/interfaces/ipc.h

src/key_io.h

src/logging/categories.h

src/logging/timer.h

src/mapport.h

src/musig.h

src/net_permissions.h

src/netgroup.h

src/netmessagemaker.h

src/node/chainstatemanager_args.cpp

src/node/connection_types.h

src/node/context.h

src/node/interface_ui.h

src/node/mempool_args.cpp

src/node/mining_args.cpp

src/node/minisketchwrapper.cpp

src/node/txreconciliation.h

src/policy/fees/estimator_args.cpp

src/policy/fees/estimator_args.h

src/policy/fees/estimator_man.cpp

src/policy/fees/estimator_man.h

src/policy/packages.h

src/policy/rbf.h

src/policy/truc_policy.h

src/pow.h

src/primitives/block.cpp

src/randomenv.h

src/rest.h

src/script/keyorigin.h

src/script/parsing.cpp

src/script/parsing.h

src/script/script_error.h

src/script/sigcache.cpp

src/script/sigcache.h

src/script/solver.h

src/script/verify_flags.h

src/semaphore_grant.h

src/signet.h

src/span.h

src/support/allocators/secure.h

src/support/allocators/zeroafterfree.h

src/util/tokenpipe.cpp

src/util/translation.h

src/util/vector.h

src/versionbits.h

src/versionbits_impl.h

src/wallet/external_signer_scriptpubkeyman.h

src/wallet/fees.h

src/wallet/load.h

src/wallet/receive.h

src/wallet/rpc/wallet.h

src/wallet/types.h

src/walletinitinterface.h

src/zmq/zmqabstractnotifier.cpp

Independent explanations by MyBitcoinExplorer. Not affiliated with or endorsed by Bitcoin Core. Guides are educational and do not replace the source or its tests.

Bitcoin Core source © its contributors, distributed under the MIT license. Original notices and bundled third-party licenses are retained in the source tree.