Inside Bitcoin

501                             success=False,
502                             error_code=-4,
503                             error_message='Cannot import private keys to a wallet with private keys disabled')
504
505        self.log.info("Should not import a descriptor with hardened derivations when private keys are disabled")
506        self.test_importdesc({"desc": descsum_create("wpkh(" + xpub + "/1h/*)"),
507                              "timestamp": "now",
508                              "range": 1},
509                             success=False,
510                             error_code=-4,
511                             error_message='Cannot expand descriptor. Probably because of hardened derivations without private keys provided')
512
513        for address in addresses:
514            test_address(w1,
515                         address,
516                         ismine=False,
517                         solvable=False)
518
519        self.test_importdesc({"desc": descsum_create(desc), "timestamp": "now", "range": -1},
520                              success=False, error_code=-8, error_message='End of range is too high')
521
522        self.test_importdesc({"desc": descsum_create(desc), "timestamp": "now", "range": [-1, 10]},
523                              success=False, error_code=-8, error_message='Range should be greater or equal than 0')
524
525        self.test_importdesc({"desc": descsum_create(desc), "timestamp": "now", "range": [(2 << 31 + 1) - 1000000, (2 << 31 + 1)]},
526                              success=False, error_code=-8, error_message='End of range is too high')
527
528        self.test_importdesc({"desc": descsum_create(desc), "timestamp": "now", "range": [2, 1]},
529                              success=False, error_code=-8, error_message='Range specified as [begin,end] must not have begin after end')
530
531        self.test_importdesc({"desc": descsum_create(desc), "timestamp": "now", "range": [0, 1000001]},
532                              success=False, error_code=-8, error_message='Range is too large')
533
534        self.log.info("Verify we can only extend descriptor's range")
535        range_request = {"desc": descsum_create(desc), "timestamp": "now", "range": [5, 10], 'active': True}
536        self.test_importdesc(range_request, wallet=wpriv, success=True)
537        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 6)
538        self.test_importdesc({**range_request, "range": [0, 10]}, wallet=wpriv, success=True)
539        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 11)
540        self.test_importdesc({**range_request, "range": [0, 20]}, wallet=wpriv, success=True)
541        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 21)
542        # Can keep range the same
543        self.test_importdesc({**range_request, "range": [0, 20]}, wallet=wpriv, success=True)
544        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 21)
545
546        self.test_importdesc({**range_request, "range": [5, 10]}, wallet=wpriv, success=False,
547                             error_code=-4, error_message=f"Could not add descriptor '{range_request['desc']}': new range must include current range = [0,20]")
548        self.test_importdesc({**range_request, "range": [0, 10]}, wallet=wpriv, success=False,
549                             error_code=-4, error_message=f"Could not add descriptor '{range_request['desc']}': new range must include current range = [0,20]")
550        self.test_importdesc({**range_request, "range": [5, 20]}, wallet=wpriv, success=False,
551                             error_code=-4, error_message=f"Could not add descriptor '{range_request['desc']}': new range must include current range = [0,20]")
552        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 21)
553
554        self.log.info("Check we can change descriptor internal flag")
555        self.test_importdesc({**range_request, "range": [0, 20], "internal": True}, wallet=wpriv, success=True)
556        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 0)
557        assert_raises_rpc_error(-4, 'This wallet has no available keys', wpriv.getnewaddress, '', 'p2sh-segwit')
558        assert_equal(wpriv.getwalletinfo()['keypoolsize_hd_internal'], 21)
559        wpriv.getrawchangeaddress('p2sh-segwit')
560
561        self.test_importdesc({**range_request, "range": [0, 20], "internal": False}, wallet=wpriv, success=True)
562        assert_equal(wpriv.getwalletinfo()['keypoolsize'], 21)
563        wpriv.getnewaddress('', 'p2sh-segwit')
564        assert_equal(wpriv.getwalletinfo()['keypoolsize_hd_internal'], 0)
565        assert_raises_rpc_error(-4, 'This wallet has no available keys', wpriv.getrawchangeaddress, 'p2sh-segwit')
566
567        # Make sure ranged imports import keys in order
568        w1 = self.nodes[1].get_wallet_rpc('w1')
569        self.log.info('Key ranges should be imported in order')
570        xpub = "tpubDAXcJ7s7ZwicqjprRaEWdPoHKrCS215qxGYxpusRLLmJuT69ZSicuGdSfyvyKpvUNYBW1s2U3NSrT6vrCYB9e6nZUEvrqnwXPF8ArTCRXMY"
571        addresses = [
572            'bcrt1qtmp74ayg7p24uslctssvjm06q5phz4yrxucgnv', # m/0'/0'/0
573            'bcrt1q8vprchan07gzagd5e6v9wd7azyucksq2xc76k8', # m/0'/0'/1
574            'bcrt1qtuqdtha7zmqgcrr26n2rqxztv5y8rafjp9lulu', # m/0'/0'/2
575            'bcrt1qau64272ymawq26t90md6an0ps99qkrse58m640', # m/0'/0'/3
576            'bcrt1qsg97266hrh6cpmutqen8s4s962aryy77jp0fg0', # m/0'/0'/4
577        ]
578
579        self.test_importdesc({'desc': descsum_create('wpkh([80002067/0h/0h]' + xpub + '/*)'),
580                              'active': True,
581                              'range' : [0, 2],
582                              'timestamp': 'now'
583                             },
584                             success=True)
585        self.test_importdesc({'desc': descsum_create('sh(wpkh([abcdef12/0h/0h]' + xpub + '/*))'),
586                              'active': True,
587                              'range' : [0, 2],
588                              'timestamp': 'now'
589                             },
590                             success=True)
591        self.test_importdesc({'desc': descsum_create('pkh([12345678/0h/0h]' + xpub + '/*)'),
592                              'active': True,
593                              'range' : [0, 2],
594                              'timestamp': 'now'
595                             },
596                             success=True)
597
598        assert_equal(w1.getwalletinfo()['keypoolsize'], 5 * 3)
599        for i, expected_addr in enumerate(addresses):
600            received_addr = w1.getnewaddress('', 'bech32')
601            assert_raises_rpc_error(-4, 'This wallet has no available keys', w1.getrawchangeaddress, 'bech32')
602            assert_equal(received_addr, expected_addr)
603            bech32_addr_info = w1.getaddressinfo(received_addr)
604            assert_equal(bech32_addr_info['desc'][:23], 'wpkh([80002067/0h/0h/{}]'.format(i))
605
606            shwpkh_addr = w1.getnewaddress('', 'p2sh-segwit')
607            shwpkh_addr_info = w1.getaddressinfo(shwpkh_addr)
608            assert_equal(shwpkh_addr_info['desc'][:26], 'sh(wpkh([abcdef12/0h/0h/{}]'.format(i))
609
610            pkh_addr = w1.getnewaddress('', 'legacy')
611            pkh_addr_info = w1.getaddressinfo(pkh_addr)
612            assert_equal(pkh_addr_info['desc'][:22], 'pkh([12345678/0h/0h/{}]'.format(i))
613
614            assert_equal(w1.getwalletinfo()['keypoolsize'], 4 * 3) # After retrieving a key, we don't refill the keypool again, so it's one less for each address type
615        w1.keypoolrefill()
616        assert_equal(w1.getwalletinfo()['keypoolsize'], 5 * 3)
617
618        self.log.info("Check we can change next_index")
619        # go back and forth with next_index
620        for i in [4, 0, 2, 1, 3]:
621            # Sometimes use h, sometimes use ' for hardened indicator
622            hard = "'" if i & 2 == 0 else "h"
623            self.test_importdesc({'desc': descsum_create(f'wpkh([80002067/0{hard}/0{hard}]' + xpub + '/*)'),
624                                  'active': True,
625                                  'range': [0, 9],
626                                  'next_index': i,
627                                  'timestamp': 'now'
628                                  },
629                                 success=True)
630            assert_equal(w1.getnewaddress('', 'bech32'), addresses[i])
631
632        self.log.info("Equivalent Miniscript descriptors should not be duplicated")
633        self.nodes[1].createwallet(wallet_name="wminiscript", disable_private_keys=True, blank=True)
634        wminiscript = self.nodes[1].get_wallet_rpc("wminiscript")
635        miniscript_request = {
636            'active': True,
637            'range': [0, 9],
638            'timestamp': 'now',
639        }
640        self.test_importdesc({
641            **miniscript_request,
642            'desc': descsum_create(f"wsh(and_v(v:pk([80002067/0h/0h]{xpub}/*),older(1)))"),
643        }, success=True, wallet=wminiscript)
644        self.test_importdesc({
645            **miniscript_request,
646            'desc': descsum_create(f"wsh(and_v(v:pk([80002067/0'/0']{xpub}/*),older(1)))"),
647        }, success=True, wallet=wminiscript)
648        assert_equal(len(wminiscript.listdescriptors()["descriptors"]), 1)
649
650        # Check active=False default
651        self.log.info('Check imported descriptors are not active by default')
652        self.test_importdesc({'desc': descsum_create('pkh([12345678/1h]' + xpub + '/*)'),
653                              'range' : [0, 2],
654                              'timestamp': 'now',
655                              'internal': True
656                             },
657                             success=True)
658        assert_raises_rpc_error(-4, 'This wallet has no available keys', w1.getrawchangeaddress, 'legacy')
659
660        self.log.info('Check can activate inactive descriptor')
661        self.test_importdesc({'desc': descsum_create('pkh([12345678]' + xpub + '/*)'),
662                              'range': [0, 5],
663                              'active': True,
664                              'timestamp': 'now',
665                              'internal': True
666                              },
667                             success=True)
668        address = w1.getrawchangeaddress('legacy')
669        assert_equal(address, "mpA2Wh9dvZT7yfELq1UnrUmAoc5qCkMetg")
670
671        self.log.info('Check can deactivate active descriptor')
672        self.test_importdesc({'desc': descsum_create('pkh([12345678]' + xpub + '/*)'),
673                              'range': [0, 5],
674                              'active': False,
675                              'timestamp': 'now',
676                              'internal': True
677                              },
678                             success=True)
679        assert_raises_rpc_error(-4, 'This wallet has no available keys', w1.getrawchangeaddress, 'legacy')
680
681        self.log.info('Verify activation state is persistent')
682        w1.unloadwallet()
683        self.nodes[1].loadwallet('w1')
684        assert_raises_rpc_error(-4, 'This wallet has no available keys', w1.getrawchangeaddress, 'legacy')
685
686        # # Test importing a descriptor containing a WIF private key
687        wif_priv = "cTe1f5rdT8A8DFgVWTjyPwACsDPJM9ff4QngFxUixCSvvbg1x6sh"
688        address = "2MuhcG52uHPknxDgmGPsV18jSHFBnnRgjPg"
689        desc = "sh(wpkh(" + wif_priv + "))"
690        self.log.info("Should import a descriptor with a WIF private key as spendable")
691        self.test_importdesc({"desc": descsum_create(desc),
692                               "timestamp": "now"},
693                              success=True,
694                              wallet=wpriv)
695
696        self.log.info('Test can import same descriptor with private key twice')
697        self.test_importdesc({"desc": descsum_create(desc), "timestamp": "now"}, success=True, wallet=wpriv)
698
699        test_address(wpriv,
700                     address,
701                     solvable=True,
702                     ismine=True)
703        txid = w0.sendtoaddress(address, 49.99995540)
704        self.generatetoaddress(self.nodes[0], 6, w0.getnewaddress())
705        tx = wpriv.createrawtransaction([{"txid": txid, "vout": 0}], {w0.getnewaddress(): 49.999})
706        signed_tx = wpriv.signrawtransactionwithwallet(tx)
707        w1.sendrawtransaction(signed_tx['hex'])
708
709        # Make sure that we can use import and use multisig as addresses
710        self.log.info('Test that multisigs can be imported, signed for, and getnewaddress\'d')
711        self.nodes[1].createwallet(wallet_name="wmulti_priv", disable_private_keys=False, blank=True)
712        wmulti_priv = self.nodes[1].get_wallet_rpc("wmulti_priv")
713        assert_equal(wmulti_priv.getwalletinfo()['keypoolsize'], 0)
714
715        derivation_path = "84h/0h/0h"
716        change_derivation_path = "84h/1h/0h"
717        extended_key_1 = ExtendedPrivateKey.generate()
718        xprv1 = extended_key_1.to_string()
719        xprv1_fingerprint = extended_key_1._fingerprint().hex()
720        acc_xpub1_key = extended_key_1.derive_path(derivation_path).pubkey()
721        acc_xpub1 = acc_xpub1_key.to_string()
722        chg_xpub1_key = extended_key_1.derive_path(change_derivation_path).pubkey()
723        chg_xpub1 = chg_xpub1_key.to_string()
724
725        extended_key_2 = ExtendedPrivateKey.generate()
726        xprv2 = extended_key_2.to_string()
727        xprv2_fingerprint = extended_key_2._fingerprint().hex()
728        acc_xprv2 = extended_key_2.derive_path(derivation_path).to_string()
729        acc_xpub2_key = extended_key_2.derive_path(derivation_path).pubkey()
730        acc_xpub2 = acc_xpub2_key.to_string()
731        chg_xpub2_key = extended_key_2.derive_path(change_derivation_path).pubkey()
732        chg_xpub2 = chg_xpub2_key.to_string()
733
734        extended_key_3 = ExtendedPrivateKey.generate()
735        xprv3 = extended_key_3.to_string()
736        xprv3_fingerprint = extended_key_3._fingerprint().hex()
737        acc_xpub3_key = extended_key_3.derive_path(derivation_path).pubkey()
738        acc_xpub3 = acc_xpub3_key.to_string()
739        chg_xpub3_key = extended_key_3.derive_path(change_derivation_path).pubkey()
740        chg_xpub3 = chg_xpub3_key.to_string()
741
742        self.test_musig_private_key_warnings(xprv1, acc_xprv2, acc_xpub2, derivation_path)
743
744        self.test_importdesc({"desc": descsum_create(f"wsh(multi(2,{xprv1}/{derivation_path}/*,{xprv2}/{derivation_path}/*,{xprv3}/{derivation_path}/*))"),
745                            "active": True,
746                            "range": 1000,
747                            "next_index": 0,
748                            "timestamp": "now"},
749                            success=True,
750                            wallet=wmulti_priv)